Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error encountered in the wild #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mwotton
Copy link

@mwotton mwotton commented Jun 24, 2015

Not exactly sure what's going on here - the website appears perfectly cromulent.

@mwotton
Copy link
Author

mwotton commented Jun 26, 2015

i certainly can't see any reason it should crash the process

@istathar
Copy link
Member

Well your assertEqual has the wrong argument order. I assume that's not why you wrote this though.

@mwotton
Copy link
Author

mwotton commented Jun 27, 2015

Right, it us there because it throws an exception

On Sat, 27 Jun 2015 6:19 pm Andrew Cowie [email protected] wrote:

Well your assertEqual has the wrong argument order. I assume that's not
why you wrote this though.


Reply to this email directly or view it on GitHub
#91 (comment).

@istathar
Copy link
Member

@mwotton Incidentally, I can't merge this pull request as it stands; the test suite doesn't pull from external sites (can't do that from build machines!).

@istathar
Copy link
Member

So I've duplicated this. I'd imagine this web server is doing something non compliant in its response headers, but attoparsec is awful at giving you error messages. I had a branch once that tried to plumb (<?>) through the parser code, but it didn't help; our code tends to fail within takeBytes or similar, but that happens when the server is misbehaving. I suppose I should try again.

AfC

P.S. People here want to know what on earth you @mwotton was doing going to the shady website in question :)

@mwotton
Copy link
Author

mwotton commented Jun 29, 2015

Yeah, not expecting you to merge it - just an easy way of packaging up the
awful:)

On Mon, 29 Jun 2015 3:38 am Andrew Cowie [email protected] wrote:

@mwotton https://github.com/mwotton Incidentally, I can't merge this
pull request as it stands; the test suite doesn't pull from external sites
(can't do that from build machines!).


Reply to this email directly or view it on GitHub
#91 (comment).

@mwotton
Copy link
Author

mwotton commented Jun 29, 2015

I work at meanpath.com, remember? We connect to 160 million sites a day, there's got to be some shady sites in there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants