Save info when dumped and loaded by Marshal #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ROS did not play well when being dump and loaded with Marshal because the options from ROS did not translate through the serialization. This change saves the information through marshal_dump and then reassigns the information to ROS instance when the object is loaded.
wildmaples
force-pushed
the
fix-marshal-load-issue
branch
from
c569909 to
2d2271d
Compare
wildmaples
changed the title
We can recreate the hash at load.
|
Closing due to repo's inactivity |
|
@wildmaples Could you open this again? Looks like @aetherknight had time this year to perform some interactions, and this is still an issue on a 50 mio downloads gem. :( |
|
I’ll look into reviewing and merging this tonight |
|
Released as part of 1.3.0 |
|
Thank you very much! ❤️ |
This was referenced Oct 3, 2024
aetherknight
added a commit
that referenced
this pull request
Oct 4, 2024
This reverts commit 49265a8.
|
@Jack12816 @wildmaples FYI, since this is an API-breaking change, I have released 1.3.1 that reverts this change, but it's re-added in a version 2.0.0, in order to preserve semver. (See #79 for more discussion) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ROS did not play well when being dump and loaded with Marshal because the options from ROS did not translate through the serialization. This change saves the information through marshal_dump and then reassigns the information to ROS instance when the object is loaded.
(ideally) Fix: #71