-
Notifications
You must be signed in to change notification settings - Fork 28
Dataset info #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dataset info #1057
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,9 @@ class DatasetDefinition: | |
---------- | ||
name: str | ||
The name of the dataset. (default: '.') | ||
info: str | ||
Information about the dataset including but not limited to original citation, | ||
general information. (default: '.') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the default is an empty string isn't it? |
||
has_files: dict[str, bool] | ||
Indicate whether the dataset contains 'gaze', 'precomputed_events', and | ||
'precomputed_reading_measures'. | ||
|
@@ -142,6 +145,9 @@ class DatasetDefinition: | |
|
||
# pylint: disable=too-many-instance-attributes | ||
name: str = '.' | ||
|
||
info: str = '' | ||
|
||
has_files: dict[str, bool] = field(default_factory=dict) | ||
|
||
mirrors: dict[str, list[str]] | dict[str, tuple[str, ...]] = field(default_factory=dict) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ | |
class BSCII(DatasetDefinition): | ||
"""BSCII dataset :cite:p:`BSCII`. | ||
|
||
This dataset includes monocular eye tracking data from a single participant in a single | ||
This dataset includes monocular eye tracking data from several participants in a single | ||
session. Eye movements are recorded at a sampling frequency of 1,000 Hz using an EyeLink 1000 | ||
eye tracker and precomputed events on aoi level are reported. | ||
|
||
|
@@ -45,6 +45,10 @@ class BSCII(DatasetDefinition): | |
name: str | ||
The name of the dataset. | ||
|
||
info: str | ||
Information about the dataset including but not limited to original citation, | ||
general information. | ||
|
||
has_files: dict[str, bool] | ||
Indicate whether the dataset contains 'gaze', 'precomputed_events', and | ||
'precomputed_reading_measures'. | ||
|
@@ -105,6 +109,31 @@ class BSCII(DatasetDefinition): | |
|
||
name: str = 'BSCII' | ||
|
||
info: str = """\ | ||
BSCII dataset :cite:p:`BSCII`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would be in favor to remove the first line from all of the description strings, as the name of the dataset is already known to the user and the sphinx cite directive is not very useful when calling the property. Moreover, if we use the string as a basis for autogenerating dataset docpages, the first line can be easily recreated by something like Nevertheless, one thing that we could add to the description is the verbose name of the dataset.
It would be nicer to write:
|
||
|
||
This dataset includes monocular eye tracking data from several participants in a single | ||
session. Eye movements are recorded at a sampling frequency of 1,000 Hz using an EyeLink 1000 | ||
eye tracker and precomputed events on aoi level are reported. | ||
|
||
The participant is instructed to read texts and answer questions. The original purpose was to | ||
look into the differences in processing when reading simplified and traditional Chinese. | ||
|
||
Check the respective paper for details :cite:p:`BSCII`. | ||
|
||
If you use the dataset, please cite: | ||
|
||
@article{BSCII, | ||
author={Yan, Ming and Pan, Jinger and Kliegl, Reinhold}, | ||
title={The {B}eijing {S}entence {C}orpus {II}: A cross-script comparison | ||
between traditional and simplified Chinese sentence reading}, | ||
journal={Behavior Research Methods}, | ||
year={2025}, | ||
volume={57}, | ||
issue={2}, | ||
} | ||
""" | ||
|
||
has_files: dict[str, bool] = field( | ||
default_factory=lambda: { | ||
'gaze': False, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the property should return a string instead of printing it. A user can easily call
print(dataset.info)
if necessary