-
Notifications
You must be signed in to change notification settings - Fork 28
depr: deprecate GazeDataFrame
in favor of Gaze
#1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dkrako
wants to merge
26
commits into
main
Choose a base branch
from
feat/rename-gazedf-to-gaze
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 89 +2
Lines 3818 3869 +51
Branches 679 683 +4
=========================================
+ Hits 3818 3869 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
please fix merge conflicts -- will check asap afterwards |
auto-merge was automatically disabled
May 27, 2025 05:27
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarning:
GazeDataFrame
has been renamed toGaze
in v0.22.0 and will be removed in v0.27.0.Description
Renames
GazeDataFrame
to the shorterGaze
. ImplementsGazeDataFrame
as deprecated alias.The following warnings are printed on instantiation and subclassing:
Implemented changes
GazeDataFrame
toGaze
GazeDataFrame
as deprecated class aliasHow Has This Been Tested?
Context
related issues:
GazeDataFrame
toGaze
andEventDataFrame
toEvents
#921Checklist: