-
Notifications
You must be signed in to change notification settings - Fork 28
fix: copy trial_columns when copying EventDataFrame #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 87
Lines 3818 3818
Branches 679 679
=========================================
Hits 3818 3818 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care! Can you add a test to prevent regressions?
As a side note, |
This could also be changed in this PR (but can be also treated separately): pymovements/src/pymovements/gaze/gaze_dataframe.py Lines 1215 to 1228 in 028bdf6
It also doesn't clone Strange that we have |
resolves #1127
the described
d.py
now returns: