Opening cw keyboard causes sbitx to exit #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for high CPU usage and audio dropouts. Includes a define to enable debugging messages.
Changed the level of rigor from FFTW_ESTIMATE to FFTW_MEASURE in order to resolve an issue where the FFTW library would sometime make a bad choice about the FFT algorithm to use. Added support for Wisdom files so that the FFTW library does not have to spend time picking the algorithm.
Changed the level of rigor from FFTW_ESTIMATE to FFTW_MEASURE in order to resolve an issue where the FFTW library would sometimes make a bad choice about the FFT algorithm to use. Added support for Wisdom files so that the FFTW library does not have to spend time picking the algorithm.
If the screen height is set to 425 or less pixels, then when the CW keyboard is opened, the sbitx application crashes. This occurs because the calculated screen height of the waterfall becomes a negative number. That height is used in a malloc() call near line 1523 in sbitx_gtk.c Obviously the malloc() call does not work well with a negative number, so it fails, and sbitx exits. This change prevents the waterfall area from having a height less than 0, which in turn prevents the malloc() call from failing.
|
As your commit history shows and as I have verified, all that is needed relative to the current HEAD of main is the last commit ( a577fd1 ). IMO the other stuff may cause trouble later. Ideally we'd have a PR with just one commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change prevents the sbitx app from exiting when the CW keyboard is opened.