Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeaderMatchingFilter: Gracefully handle missing headers #336

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

tohojo
Copy link
Contributor

@tohojo tohojo commented Aug 24, 2023

Notmuch can raise a NullPointerException when trying to read a non-existent header from a message. Gracefully handle this in the HeaderMatchingFilter by just aborting processing when encountering such an error.

Notmuch can raise a NullPointerException when trying to read a non-existent
header from a message. Gracefully handle this in the HeaderMatchingFilter by
just aborting processing when encountering such an error.
@GuillaumeSeren
Copy link
Collaborator

Hello,
thank you for the patch.

This look like improvement to me but I would like this code to test covered,
do you mind adding a test for this ?

@tohojo
Copy link
Contributor Author

tohojo commented Sep 27, 2023 via email

Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
@GuillaumeSeren
Copy link
Collaborator

GuillaumeSeren commented Nov 21, 2023

Hey @tohojo ,
Thank you for the upgraded patch with the test support for this case.

It is LGTM 👍

@GuillaumeSeren GuillaumeSeren merged commit 3e55b17 into afewmail:master Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants