Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App keeps forgetting settings in v0.0.6 and latest git/v0.0.7 #39

Open
NovaViper opened this issue Nov 12, 2024 · 3 comments
Open

App keeps forgetting settings in v0.0.6 and latest git/v0.0.7 #39

NovaViper opened this issue Nov 12, 2024 · 3 comments

Comments

@NovaViper
Copy link

NovaViper commented Nov 12, 2024

Hey I noticed in v0.0.6 that immediately after I close the app and open it back up, it completely forgets what mods I had installed. It seems to completely ignore the SelectedMods list in the AppSettings json file while it reads all of the other options in the file. Odd thing is too is that it will save the options but as soon as I open the app back up, it just resets the mods selected and only has BSIPA selected with none of my other previously selected options. To prove the point further, I even tried to see if removing BSIPA from the AppSettings file would make a difference (to make it look like as if I selected none) and upon the next restart of the app, BSIPA was selected again. Tried with both the prepackage binary (BeatSaberModManager-linux-x64.zip) and upcoming nixpkgs update PR (which I downloaded and had to modify to get it to compile since there's a issue with the PR build's build options). The issue isn't present on 0.0.5.

Edit: Also tried it against the current git revision (8bf3611), and the bug is still present there too

(This I found out was because the commit that updated Program.cs wasn't tagged along with v0.0.6, so this is specifically in the source builds and not in the prepackaged binary) Another bug I notice is that the version number isn't correct in the Source files (which I notice that the source files weren't updated but the pre-packaged binary was)
image

System Information:

 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.7, NixOS, 24.11 (Vicuna), 24.11.20241111.3f42f0b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.23.4`
 - nixpkgs: `/nix/store/cwj8vq6zrah0qw21czisvha98lg367m0-aj5384f4ax3fg64zkxrw0b7daka0dxfr-source`
@NovaViper NovaViper changed the title App keeps forgetting settings in v0.0.6 (and version number is wrong) App keeps forgetting settings in v0.0.6 and latest git/v0.0.7 Nov 12, 2024
@NovaViper
Copy link
Author

NovaViper commented Nov 12, 2024

I'm not a full fledged C developer but I suspect this change here is what caused the breakage:
0eadaee#diff-f4e60960f750d743832012f2a0348f86d2e70cfe73cc1cd10a1b86195b13f600L50-L55

@Atemu
Copy link
Contributor

Atemu commented Dec 8, 2024

This bug is quite critical and I therefore decided to block NixOS/nixpkgs#339370.

@Atemu
Copy link
Contributor

Atemu commented Dec 8, 2024

Ugh it looks like this is because M$ is being obtuse and doesn't allow you to have the code work like that. (Oh how wise they are, they know so much better than us...)

We'll have to refactor it so that external users have simple methods to interact with this object or just expose the object directly and init it as an empty set. I also don't get why this two member variables that do the same thing complexity needs to exist in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants