beatsabermodmanager: 0.0.5 -> 0.0.7

[ImUrX]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[FliegendeWurst]

Build fails:

building '/nix/store/h27blkagnak2sabmhipwx7kxn5jrlf9y-beatsabermodmanager-0.0.6.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/snvc6h0lg7vf7ks0d66zgfpnjf1sknx6-source
source root is source
Running phase: patchPhase
Running phase: configureNuget
error: File '/build/source/nuget.config' does not exist.

[Scrumplex]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 339370

---

x86_64-linux

❌ 1 package failed to build:

• beatsabermodmanager

[Scrumplex]

Please rebase on master

[NovaViper]

Build fails:

building '/nix/store/h27blkagnak2sabmhipwx7kxn5jrlf9y-beatsabermodmanager-0.0.6.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/snvc6h0lg7vf7ks0d66zgfpnjf1sknx6-source
source root is source
Running phase: patchPhase
Running phase: configureNuget
error: File '/build/source/nuget.config' does not exist.

Same here, just tried it by overlaying it into my flake and got the same result

beatsabermodmanager> building '/nix/store/jhnhvdqxf6128lwyvpa0a6c82sm5mamc-beatsabermodmanager-0.0.6.drv'
beatsabermodmanager> Running phase: unpackPhase
beatsabermodmanager> unpacking source archive /nix/store/snvc6h0lg7vf7ks0d66zgfpnjf1sknx6-source
beatsabermodmanager> source root is source
beatsabermodmanager> Running phase: patchPhase
beatsabermodmanager> Running phase: configureNuget
beatsabermodmanager> error: File '/build/source/nuget.config' does not exist.

[NovaViper]

@ImUrX Hey I noticed the source files for the tagged version of the package hasn't been updated but the prepacked binaries have (see screenshot below)... I think it may be for the best to target against the git source instead of the tagged releases since there's been a couple of commits made that fixed the application version's number. Additionally, there's actually a pretty major bug right now that I found that the manager isn't saving the mods 😓

[ImUrX]

😓 yeah i can update the whole thing, will do it today if i dont forget

[NovaViper]

Additionally, there's actually a pretty major bug right now that I found that the manager isn't saving the mods

😓 Speaking of that... it also seems to be present in the latest git revision too. Just tried to build against it and was able to replicate the bug in that version too. We're gonna have to wait til that one gets ironed out unfortunately

[Atemu]

cc @affederaffe

[ImUrX]

and sorry for the format changes, i have alexandra on save on format but i can revert those changes if needed 😓

[Atemu]

If anything, use nixfmt-rfc-style and do it in a separate commit.

We have a standard on this.

[ImUrX]

so it should be another commit? but isnt that also against contribution guidelines
or can i just squash the nixfmt?

[ImUrX]

and if it needs to be another commit, whats the naming convention? sorry for so many questions, i just read the guidelines and it just mentions

(pkg-name): (from -> to | init at version | refactor | etc)

(Motivation for change. Link to release notes. Additional information.)

[Atemu]

so it should be another commit? but isnt that also against contribution guidelines

The action of formatting the file is one logical step and should therefore be one commit separated from all the other logical steps/commits.

I don't see how that violates any contributing guidelines, it tells you to do exactly that.

and if it needs to be another commit, whats the naming convention? sorry for so many questions, i just read the guidelines and it just mentions

(pkg-name): (from -> to | init at version | refactor | etc)

(Motivation for change. Link to release notes. Additional information.)

I'm not sure what you're confused about, it tells you right there. You're touching BSMM and what you're doing is apply nixfmt or IOW formatting the nix expressions. Following the pattern given that leaves us with: beatsabermodmanager: format using nixfmt. Stating a motivation isn't required here as it should be obvious.

If the way this section of the contributor's manual is written wasn't immediately understandable to you, please open an issue about that. Most of us don't frequently have a need to read and understand the contributor's manual and will therefore not be aware of any shortcomings.
Alternatively, you could even open a PR where you change the wording such that you would have understood it better. The contributor's manual isn't set in stone and any change to it that helps onboarding future contributors is welcome.

It's absolutely fine and even encouraged to ask questions if you're unsure about something but please always be specific in your questions so that we can effectively answer them.

[ImUrX]

cool, well should be working fine, and ready for review. thanks for the explanation!

[Atemu]

Diff LGTM, I'll see to test this soon.

[ImUrX]

should work now i think

[gepbird]

Thanks, changes LGTM, tested binary on x86_64-linux.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 339370

---

x86_64-linux

✅ 1 package built:

• beatsabermodmanager

[NovaViper]

Sadly still no word from the upstream maintainers regarding the flaw I found in the app a bit 😭

And now because of the dotsdk being marked as deprecated, I can't even install the app anymore since it's not updated

[Atemu]

IME the upstream dev does respond but will take a few months to do so. This is typical for OSS maintainers and I do the same for some of my projects.

I was going to give this some actual testing but, given that it doesn't eval on master anymore and that I didn't get around to it the past few weeks, I'm fine with merging this if someone tells me it successfully installs BS mods for them on a clean BeatSaber install (just rename the game files dir and verify files in Steam).

[Atemu]

The UI launches but mod categories are gone and none of the mods I previously selected are selected anymore. They're still in the config file though.

[Atemu]

It's the same on 0.0.6. I'll try 0.0.5 but with the newer dotnet.

[Atemu]

Doesn't work. Saving selected mods is entirely broken.

We'll have to live with 0.0.5 depending on an insecure dotnet SDK until that's fixed.

[Atemu]

Here's what you need to permit:

    nixpkgs.config.permittedInsecurePackages = [
      "dotnet-runtime-wrapped-6.0.36"
      "dotnet-runtime-wrapped-7.0.20"
      "dotnet-runtime-7.0.20"
      "dotnet-core-combined"
      "dotnet-sdk-6.0.428"
      "dotnet-sdk-7.0.410"
      "dotnet-sdk-wrapped-6.0.428"
      "dotnet-sdk-wrapped-7.0.410"
    ];

This is pain. @corngood why is every single one of these marked as insecure separately? Surely the wrappers or the combined package don't need to be as the wrapped/contained packages are already insecure.

[corngood]

@Atemu I had assumed that was because they were transitively insecure, but I guess I misunderstood. It must be because of how we're inheriting meta. It should be fixable in that case.

[Atemu]

Inheriting meta whole is generally not a good idea. Always pick the parts you actually care about.