Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update remove_line_numbers to reflect abstract code location changes #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KingBrewer
Copy link

Problem:

Since OTP 24 abstract code contains not only a line number but also a column. This causes seresye_engine:remove_line_number/1 to throw function_clause on anything newer than OTP 23.
The following is presumed breaking change: erlang/otp#3006.

Example:

What was previously: {var,{94},'Engine'} is now {var,{94,24},'Engine'}

Solution:

Add respective clauses which fallback to original functions, as line numbers are anyway ignored by the engine.

@KingBrewer
Copy link
Author

@ericbmerritt may I kindly ask to review and merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant