-
Notifications
You must be signed in to change notification settings - Fork 0
internal up to dat #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guillem-211
wants to merge
21
commits into
internal
Choose a base branch
from
main
base: internal
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding loudness settings to sdk
Fix/changelog
… tests for trace id handling
feat: add customer trace id header
* fix: pass 0 float values * chore: changelog * chore: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🛠️ Changes being made
Please include a summary of the changes and the related issue/feature.
Please also include relevant motivation and context. List any dependencies that are required for this change (e.g. other services involved)
🔬 Test Plan
How do you know the changes are safe to ship?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
🎫 Asanaticket
If there is no Asanaticket for the PR, please describe in 1-2 sentences why there is no ticket for the purposed changes.
🛫 Quality Check
Please delete options that are not relevant!
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works
Do we need to implement analytics?
Authorization enabled?
Do we have monitoring enabled?
Is the Postman collection up-to-date.
Readme of the Repo updated.
This change requires a documentation update
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Is the architecture diagram updated.