This repository has been archived by the owner on Sep 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to only merge the bottom sheet changes and the dismiss change.
This does fix following issue:
https://github.com/afollestad/material-dialogs/issues/2076
Changes
=> animation must be disabled inside a DialogFragment because this fragment will call onShow after screen rotation and also after screen off/on => this leads to collapsed sheets sometimes and to repeated animations on every screen on/off
=> if animation is disabled, everything works perfectly fine inside a DialogFragment as well now
Additionally I would have also done following:
TODO after merge (seems like you do not merge anything anymore, but still here are the steps to undo my "special" changes)
https://github.com/MFlisar/material-dialogs/blob/b8f8203513466b1c30dc8046ef5e61a3e61495b5/gradle/android_library_config.gradle#L6-L9
https://github.com/MFlisar/material-dialogs/blob/b8f8203513466b1c30dc8046ef5e61a3e61495b5/gradle/android_common_config.gradle#L6
Note
If someone else wants to use it already, it's already published on jitpack and can be used like following: