Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrefCoroutines.kt #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

glovebx
Copy link

@glovebx glovebx commented Jan 29, 2021

seems destroy() was not invoked properly. onChanged array in RealPref.kt remains old listener(s) will cause JobCancellationException, For example when fragment created again

Guidelines

  1. You must run the spotlessApply task before commiting, either through Android Studio or with ./gradlew spotlessApply.
  2. A PR should be focused and contained. If you are changing multiple unrelated things, they should be in separate PRs.
  3. A PR should fix a bug or solve a problem - something that only you would use is not necessarily something that should be published.
  4. Give your PR a detailed title and description - look over your code one last time before actually creating the PR. Give it a self-review.

If you do not follow the guidelines, your PR will be rejected.

seems destroy() was not invoked properly. onChanged array in RealPref.kt remains old listener(s) will cause JobCancellationException, For example when fragment created again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant