another test for conditional

afragen · Dec 18, 2024 · 7057264 · 7057264
1 parent ed15f8c
commit 7057264
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Git_Updater/REST/REST_API.php b/src/Git_Updater/REST/REST_API.php
@@ -403,14 +403,15 @@ public function get_api_data( \WP_REST_Request $request ) {
 			'external'          => 'xxx',
 		];
 
-		if ( $repo_api_data['is_private'] || in_array( $repo_api_data['git'], [ 'gitlab', 'gitea' ], true )
+		$repo_cache = $this->get_repo_cache( $slug );
+
+		if ( $repo_api_data['download_link'] && $repo_api_data['is_private'] || in_array( $repo_api_data['git'], [ 'gitlab', 'gitea' ], true )
 		) {
 			$repo_api_data['auth_header'] = Singleton::get_instance( 'Fragen\Git_Updater\API\API', $this )->add_auth_header( [], $repo_api_data['download_link'] );
 			$repo_api_data['auth_header'] = Singleton::get_instance( 'Fragen\Git_Updater\API\API', $this )->unset_release_asset_auth( $repo_api_data['auth_header'], $repo_api_data['download_link'] );
 		}
 
 		if ( $download && $repo_data->release_asset ) {
-			$repo_cache = $this->get_repo_cache( $slug );
 			if ( isset( $repo_cache['release_asset_redirect'] ) ) {
 				$repo_api_data['download_link'] = $repo_cache['release_asset_redirect'];
 			} elseif ( $repo_cache['release_asset'] ) {