Don't transpile to ES5 #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
force-pushed
the
dont-transpile-to-es5
branch
from
f1e7a4e
to
f8f9035
Compare
|
I just had the idea to do this PR while watching https://www.youtube.com/watch?v=odhjF1obcUo |
|
To use it: <a-scene inspector="url: https://cdn.jsdelivr.net/gh/aframevr/aframe-inspector@ddda46f4376cf696e623721d98e1c2eb3e799b73/dist/aframe-inspector.min.js"> |
|
We could also just remove the single test https://github.com/aframevr/aframe-inspector/blob/master/src/components/__tests__/Collapsible.test.js and jest, babel-jest, react-test-renderer dependencies instead of reintroducing @babel/preset-env in f8f9035 |
|
Yeah we don't need to transpile to ES5 I think. Is this ready to merge? |
|
You can merge as is yes. |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used
@babel/preset-envwithout browserlist config inpackage.json, so@babel/preset-envdefaulted to ES5 and not browserlistdefaultsquery that applies modern browsers. See dochttps://babeljs.io/docs/babel-preset-env
https://babeljs.io/docs/options#no-targets
but really nowadays we don't need to transpile to ES5, that was at a time we needed to support IE11.
We don't use any fancy javascript syntax here, only ES6/ES2015 that is supported by all supported browsers.
Bundle size reduced from 521K to 426K. Transpiling to ES5 included lots of polyfills we don't need.