Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be sure an entity doesn't use the same id as a mixin in the examples #775

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

vincentfretin
Copy link
Contributor

document.getElementById("blueBox") returned the mixin and not the entity because both the mixin and the entity had the same id. I changed the id on the entity to not conflict. An id should be unique in an html page. @dmarcos

@dmarcos
Copy link
Member

dmarcos commented Nov 14, 2024

Thank you!

@dmarcos dmarcos merged commit 4b915f4 into aframevr:master Nov 14, 2024
1 check passed
@vincentfretin vincentfretin deleted the unique-ids branch November 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants