Skip to content

Commit

Permalink
fixes (#63)
Browse files Browse the repository at this point in the history
  • Loading branch information
evandcoleman authored Sep 30, 2024
1 parent db36319 commit 44a7342
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,19 @@ jobs:
run: |
artifact_name="Firebase.zip"
echo "Getting release ID for $REPO version $VERSION"
# Get the release ID for the specific version
release_id=$(gh api repos/$REPO/releases/tags/$VERSION --jq '.id')
echo "Getting release notes for $REPO version $VERSION"
echo "Release ID: $release_id"
echo "Getting release notes for $REPO version $VERSION"
# Get release notes
release_notes=$(gh release view $release_id --repo $REPO --json body | jq -r '.body')
release_notes=$(gh release view $VERSION --repo $REPO --json body | jq -r '.body')
echo "::set-output name=release_notes::${release_notes}"
echo "Downloading artifact from $REPO version $VERSION"
# Download the release artifact for that release ID
gh release download $release_id --repo $REPO --pattern $artifact_name --dir ./
gh release download $VERSION --repo $REPO --pattern $artifact_name --dir ./
env:
REPO: firebase/firebase-ios-sdk
VERSION: ${{ steps.extract_version.outputs.version }}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ jobs:

echo "Creating a release for version $version"

firebase_release_id=$(gh api repos/$FIREBASE_REPO/releases/tags/$VERSION --jq '.id')
release_notes=$(gh release view $release_id --repo $FIREBASE_REPO --json body | jq -r '.body')
release_notes=$(gh release view $VERSION --repo $FIREBASE_REPO --json body | jq -r '.body')

# Create a new release
gh release create $version ./artifacts/* \
Expand Down

0 comments on commit 44a7342

Please sign in to comment.