Fix: Missed many places where SUCCESSFULL state is used

ag-computational-bio · Jan 7, 2025 · cd057bb · cd057bb
1 parent 5fb87b0
commit cd057bb
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/src/model/job.ts b/src/model/job.ts
@@ -7,7 +7,7 @@ export const JobSchema = z.object({
 
 export const JobStatusSchema = z.object({
   jobId: z.string(),
-  jobStatus: z.enum(['INIT', 'RUNNING', 'SUCCESSFULL', 'ERROR']),
+  jobStatus: z.enum(['INIT', 'RUNNING', 'SUCCESSFULL', 'SUCCESSFUL', 'ERROR']),
   name: z.string(),
   started: z.string(),
   updated: z.string(),

diff --git a/src/pages/show-job-list/JobsTable.stories.ts b/src/pages/show-job-list/JobsTable.stories.ts
@@ -40,7 +40,7 @@ export const Default: Story = {
       },
       {
         jobID: 'd',
-        jobStatus: 'SUCCESSFULL',
+        jobStatus: 'SUCCESSFUL',
         key: 'D',
         name: 'good genome',
         started: '2006-06-06T02:02:02Z',

diff --git a/src/pages/show-job-list/JobsTable.vue b/src/pages/show-job-list/JobsTable.vue
@@ -83,13 +83,13 @@ function stateIcon(state: JobStatus | FailedJobStatus): string {
       return 'bi bi-hourglass'
     case 'RUNNING':
       return 'bi bi-gear'
+    case 'SUCCESSFUL':
     case 'SUCCESSFULL':
       return 'bi bi-check2-circle'
     case 'NOT_FOUND':
     case 'UNAUTHORIZED':
     case 'ERROR':
       return 'bi bi-x-circle'
   }
-  return 'bi bi-x-circle'
 }
 </script>
diff --git a/src/pages/show-job-list/ListJobsPage.vue b/src/pages/show-job-list/ListJobsPage.vue
@@ -37,6 +37,7 @@ const { start, polling, cancel } = usePollManager(
     x.every(
       (j) =>
         j.jobStatus === 'SUCCESSFULL' ||
+        j.jobStatus === 'SUCCESSFUL' ||
         j.jobStatus === 'ERROR' ||
         j.jobStatus === 'UNAUTHORIZED' ||
         j.jobStatus === 'NOT_FOUND',

diff --git a/src/pages/show-results/ShowResultPage.vue b/src/pages/show-results/ShowResultPage.vue
@@ -44,7 +44,7 @@ function loadJobData() {
     .then((j) => {
       job.value = j
       const status = job.value.jobStatus
-      if (status === 'SUCCESSFULL' || status === 'ERROR') {
+      if (status === 'SUCCESSFULL' || status === 'SUCCESSFUL' || status === 'ERROR') {
         //  jobs is in finished state. No retry required
         console.debug('Jobs is finished or failed, no need to refresh', job.value)
         return bakta.result(jobToken).then((r) => {