Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

agGridColumn: missing column properties #25

Open
mroseboom opened this issue Jan 30, 2018 · 5 comments
Open

agGridColumn: missing column properties #25

mroseboom opened this issue Jan 30, 2018 · 5 comments

Comments

@mroseboom
Copy link
Contributor

I'm submitting a ...

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid-aurelia/blob/master/CONTRIBUTING.md#question

Current behavior
agGridColumn does not support the following properties:

  • suppressToolPanel
  • suppressKeyboardEvent(params)

Expected behavior
agGridColumn should support those attributes

What is the motivation / use case for changing the behavior?
Should be able to use the built-in column properties on the ag-grid-column component.

Please tell us about your environment:

  • ag-grid-aurelia version: 16.0.0

  • ag-Grid/ag-Grid-Enterprise version: 16.0.0

  • Aurelia version: 16.0.0

  • Browser: all

  • Language: all

mroseboom added a commit to mroseboom/ag-grid-aurelia that referenced this issue Jan 30, 2018
add support for the properties suppressToolPanel & suppressKeyboardEvent within the grid-column. This pr is a fix for issue [ag-grid#25](ag-grid#25)
@ShaunVanDyk
Copy link

Is rowDrag also missing? This was added in v16: https://www.ag-grid.com/javascript-grid-row-dragging/#managed-dragging

@mroseboom
Copy link
Contributor Author

@ShaunVanDyk You're right, the property rowDrag is also missing. I'll add that one too.

@mroseboom
Copy link
Contributor Author

Added both new properties rowData and toolPanelClass in the pull-request

@avrahamcool
Copy link

looks like lockPinned is also missing.

https://www.ag-grid.com/javascript-grid-pinning/

@mroseboom
Copy link
Contributor Author

@avrahamcool lockPinned is added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants