Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

fix(agGridColumn): add missing attributes #26

Closed
wants to merge 3 commits into from

Conversation

mroseboom
Copy link
Contributor

add support for the properties suppressToolPanel & suppressKeyboardEvent within the grid-column. This pr is a fix for issue #25

add support for the properties suppressToolPanel & suppressKeyboardEvent within the grid-column. This pr is a fix for issue [ag-grid#25](ag-grid#25)
@mroseboom
Copy link
Contributor Author

Is it an idea to use the colDefUtil file for the bindable properties?

Example usage:

import { ColDefUtil } from "ag-grid/main";

@customElement('ag-grid-column')
@generateBindables(ColDefUtil.ALL_PROPERTIES) <--
// <slot> is required for @children to work.  https://github.com/aurelia/templating/issues/451#issuecomment-254206622
@inlineView(`<template><slot></slot></template>`)
@autoinject()
export class AgGridColumn {
   ...
}

@mroseboom
Copy link
Contributor Author

@seanlandsman Do you have an idea when this pr can be merged?

@mroseboom
Copy link
Contributor Author

any update on when this pull-request can be reviewed/merged?

@seanlandsman
Copy link
Member

Hi

Apologies for the delay - this project is now deprecated. The replacement repo can be found at https://github.com/ag-grid/ag-grid.

I've manually taken this PR and applied it to the new repo. The changes will be available in the next release.

thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants