Merge pull request #819 from imobachgs/fix-client-initialization

Fix client initialization
agama-project · Oct 26, 2023 · 320b580 · 320b580
2 parents 55010d7 + 9863c71
commit 320b580
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/web/package/cockpit-agama.changes b/web/package/cockpit-agama.changes
@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Thu Oct 26 05:31:28 UTC 2023 - Imobach Gonzalez Sosa <[email protected]>
+
+- Fix client initialization to avoid a useless reconnection
+  (gh#openSUSE/agama#819).
+
 -------------------------------------------------------------------
 Mon Oct 23 11:33:53 UTC 2023 - Imobach Gonzalez Sosa <[email protected]>
 

diff --git a/web/src/context/installer.jsx b/web/src/context/installer.jsx
@@ -84,6 +84,7 @@ function InstallerClientProvider({
       if (await client.isConnected()) {
         setValue(client);
         setAttempt(0);
+        return;
       }
 
       console.warn(`Failed to connect to D-Bus (attempt ${attempt + 1})`);

diff --git a/web/src/context/installer.test.jsx b/web/src/context/installer.test.jsx
@@ -63,7 +63,7 @@ describe("installer context", () => {
         <InstallerClientProvider interval={0.1}>
           <ClientStatus />
         </InstallerClientProvider>);
-      await screen.findByText("attempt: 2");
+      await screen.findByText("attempt: 1");
     });
   });