-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Show candidate devices #658
Merged
joseivanlopez
merged 5 commits into
agama-project:master
from
joseivanlopez:cli-storage-boot-device
Jul 13, 2023
Merged
CLI: Show candidate devices #658
joseivanlopez
merged 5 commits into
agama-project:master
from
joseivanlopez:cli-storage-boot-device
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
cli-storage-boot-device
branch
from
July 12, 2023 11:04
4dd7702
to
6f33a43
Compare
joseivanlopez
force-pushed
the
cli-storage-boot-device
branch
from
July 12, 2023 12:10
9a86952
to
9102802
Compare
joseivanlopez
changed the title
CLI show candidate devices
[cli] Show candidate devices
Jul 12, 2023
joseivanlopez
changed the title
[cli] Show candidate devices
CLI: Show candidate devices
Jul 12, 2023
Co-authored-by: Imobach González Sosa <[email protected]>
- Yaml already does it.
joseivanlopez
force-pushed
the
cli-storage-boot-device
branch
from
July 13, 2023 08:46
9102802
to
3c842b0
Compare
imobachgs
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but, please, add the entry to the changes file.
joseivanlopez
force-pushed
the
cli-storage-boot-device
branch
from
July 13, 2023 08:56
3c842b0
to
4e726cc
Compare
imobachgs
approved these changes
Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The information about the selected storage candidate devices is not shown by
agama config show
command.Note: this is a Rust introductory card. The goal is to get familiar with the code and start writing some bits. The format of the storage settings (including the candidate devices) is going to be changed soon, see #656.
Solution
Loads the information about the candidate devices.
Bonus: print a new line for text and json formats.
Testing