Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Show candidate devices #658

Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jul 11, 2023

Problem

The information about the selected storage candidate devices is not shown by agama config show command.

Note: this is a Rust introductory card. The goal is to get familiar with the code and start writing some bits. The format of the storage settings (including the candidate devices) is going to be changed soon, see #656.

Solution

Loads the information about the candidate devices.

Bonus: print a new line for text and json formats.

$ agama -f json config show 
{"user":{"fullName":"","userName":"","password":"","autologin":false},"root":{"sshPublicKey":null},
"software":{"product":"Tumbleweed"},"storage":{"lvm":null,"encryptionPassword":null,
"devices":[{"name":"/dev/vdb"}]},"network":{"connections":[{"id":"enp1s0","method":"auto"},
{"id":"lo","method":"manual","addresses":["127.0.0.1/8"]}]}}
$

Testing

  • Tested manually

@joseivanlopez joseivanlopez changed the title CLI show boot device CLI show candidate devices Jul 12, 2023
@joseivanlopez joseivanlopez marked this pull request as ready for review July 12, 2023 12:18
@joseivanlopez joseivanlopez changed the title CLI show candidate devices [cli] Show candidate devices Jul 12, 2023
@coveralls
Copy link

coveralls commented Jul 12, 2023

Coverage Status

coverage: 72.339% (-0.06%) from 72.398% when pulling d35c294 on joseivanlopez:cli-storage-boot-device into f33d147 on openSUSE:master.

@joseivanlopez joseivanlopez changed the title [cli] Show candidate devices CLI: Show candidate devices Jul 12, 2023
joseivanlopez and others added 3 commits July 13, 2023 09:40
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but, please, add the entry to the changes file.

@joseivanlopez joseivanlopez merged commit 9243267 into agama-project:master Jul 13, 2023
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants