Regenerate package-lock.json #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the file was missing the "resolved" and "integrity" keys for the packages.
imobachgs
approved these changes
Nov 2, 2023
dgdavid
added a commit
that referenced
this pull request
Nov 15, 2023
Another boring PR for keeping dependencies up-to-date via `npm update` and `npm install @package/name@latest`. No more `--lockfile-version 2` because [OBS already supports version 3](https://github.com/openSUSE/obs-service-node_modules/blob/2153192f0baf8453c12bacf7b872c0c786ed645f/node_modules.py#L342-L343) as we realized at #843 Please, note that this time we manage to get rid of some dependencies which were there because cockpit-starter-kit (see #127) but actually not needed anymore. In fact, they are no longer dependencies of starter-kit. Namely, * [core-js](https://github.com/zloirock/core-js) - As a weird side effect, few tests were _fixed_ to wait a bit for the expected content. Some black magic around _Promise.resolve_, I guess. Honestly, I didn't dig too further on it since waiting for the content is somehow _expected_. * [stdio](https://github.com/sgmonda/stdio) * [sizzle](https://www.npmjs.com/package/sizzle) Apart from these, [regenerator-runtime](https://github.com/facebook/regenerator) was dropped too because > It was added more than a year ago in the context of "Adapt React > components to the Starter Kit". But probably is no longer needed since > async functions, ES6 generators, and `yield` JavaScript operator have > broad support among major browsers. --- * [web] Update dependencies via `npm update` * [web] Update icons packages to their latest version * [web] Update Patternfly libraries to latest version * [web] Drop core-js dependency It was added because of cockpit-starter-kit[1] but they already dropped it[2] because > starter-kit does not use it directly, and none of our derived projects > have it. Thus, in principle it does not make sense to keep it as Agama dependency. As weird side-effect, a few test were fixed to "waitFor" the expeced content. [1] 55c75c3 [2] cockpit-project/starter-kit@67c1c06 * [web] Update fast-sort to its latest version * [web] Update ippadr.js to its latest version * [web] Drop regenerator-runtime dependency It[1] was added more than a year ago[2] in the context of "Adapt React components to the Starter Kit". But probably is no longer needed since async functions, ES6 generators, and `yield` JavaScript operator have broad support among major browsers. [1] https://github.com/facebook/regenerator [2] 55c75c3 * [web] Update sprintf-js to the latest version * [web] Update typedoc and related dependencies * [web] Update webpack and related dependencies * [web] Update stylint and related dependencies * [web] Update @babel and related dependencies * [web] Update cspell dev dependencies * [web] More babel dev dependencies updates * [web] Update eslint and eslint-config dependencies * [web] Update eslint-plugin dependencies * [web] Update jest dependencies * [web] Update jsdoc dependency * [web] Update sass dependencies * [web] Update terser-webpack-plugin * [web] Drop stdio dev dependency It was there because cockpit-starter-kit, which dropped it a year ago[1][2] [1] cockpit-project/starter-kit#590 [2] cockpit-project/starter-kit@6e1fd84 * [web] Drop sizzle dev dependency Which came from cockpit-starter-kit. It was dropped there few months ago, in Jun 2023[1] [1] cockpit-project/starter-kit@1e46595 * [web] Update qunit dev dependency to latest version * [web] Update mini-css-extract-plugin * [web] Update ajv dev dependency * [web] Update @testing-library dependencies * [web] Update @typescript-eslint dependencies * [web] Update @types/jest * [web] Adapt FileViewer test For waiting for the expected content * [web] Fix NetworkPage test Remove a leftover it.only and make examples wait a bit for the expected content. * [web] Little improvement in Sidebar test * [web] Update ProductPage test For waiting a bit to find the expected content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the file was missing the "resolved" and "integrity" keys for the packages. That cause the OBS service to fail to fetch the NPM packages.
The diff is HUGE and cannot be displayed here, but the changes are basically like this: