Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken integration test, the setup-service.sh script has been renamed to setup-services.sh #920

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fixed broken integration test, the setup-service.sh script has been renamed to setup-services.sh #920

merged 2 commits into from
Dec 8, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Dec 8, 2023

Problem

  • The integration test fails
  • The problem is that the setup-service.sh script has been renamed to setup-services.sh in Add package dependencies #911 but not all places which use it were fixed

Solution

  • Fix the script name everywhere

@coveralls
Copy link

coveralls commented Dec 8, 2023 •
edited
Loading

Coverage Status

coverage: 75.055%. remained the same
when pulling 169afc9 on script_rename
into 3953469 on master.

mvidner
mvidner approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lslezak lslezak merged commit 9145cfa into master Dec 8, 2023
2 checks passed
@lslezak lslezak deleted the script_rename branch December 8, 2023 09:51
@imobachgs imobachgs mentioned this pull request Dec 21, 2023
Merged
imobachgs added a commit that referenced this pull request Dec 21, 2023
@imobachgs
Update to release 7 (#947)
a1c7f33 
* #915
* #916
* #917
* #919
* #920
* #921
* #922
* #923
* #924
* #925
* #926
* #927
* #928
* #929
* #930
* #931
* #933
* #934
* #935
* #936
* #937
* #938
* #939
* #940
* #941
* #942
* #943
* #944
* #945
* #946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lslezak @coveralls @mvidner