Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made contact us form accessible ✨ #692

Closed
wants to merge 3 commits into from
Closed

feat: made contact us form accessible ✨ #692

wants to merge 3 commits into from

Conversation

0xabdulkhaliq
Copy link
Contributor

Related Issue

Close #685

Proposed Changes

  • Added proper Labels for all input fields on Contact us form.
  • Associated every input elements with their Corresponding Input element using for, name & id Attributes to ensure semantic markup
  • Finally hide the labels using screen reader only styles which, they can't be seen but they can be accessible for screen readers like accessibility devices.

Checklist

  • ✅ My code follows the code style of this project.

  • 📝 My change requires a change to the documentation.

  • 🎀 I have updated the documentation accordingly.

  • 🌟 ed the repo

  • New feature (non-breaking change which adds functionality)

Output Screenshots

  • We can't capture accessibility changes through screenshots as opposed to code changes since accessibility modifications are often imperceptible to the user, as their purpose is to assist disabled individuals.

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for codesetgo ready!

Name Link
🔨 Latest commit 475a46b
🔍 Latest deploy log https://app.netlify.com/sites/codesetgo/deploys/64d445bce892c7000871a218
😎 Deploy Preview https://deploy-preview-692--codesetgo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xabdulkhaliq
Copy link
Contributor Author

Your review is appreciated @agamjotsingh18 🙌🏻

@agamjotsingh18
Copy link
Owner

Pr has conflicts

@0xabdulkhaliq
Copy link
Contributor Author

Please merge this PR now @agamjotsingh18

@0xabdulkhaliq 0xabdulkhaliq closed this by deleting the head repository Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve contact form accessibility using semantic labels 🪄✨
2 participants