Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inferable arguments implicit in Product.Indexed.{commute,unqiue} #459

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

Taneb
Copy link
Member

@Taneb Taneb commented Mar 3, 2025

Continuing to slowly work through a series of nits

Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

ψ⇒ i C.∘ K⇒ ∎
Keq : {i : ∃₂ J._⇒_} → ϕ⇒ i C.∘ K⇒ C.≈ ψ⇒ i C.∘ K⇒
Keq = begin
_ C.∘ K⇒ ≈⟨ OP.commute ⟩
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy to remove inferable things 'on the right' but less so on the left (no need to revert these here - just a general comment.) Stuff on the left serves as documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was at least in part justifying to myself that the arguments could be inferred and hence were safe to remove

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the left of most equational proofs, you can replace everything by _ and it still works...

@JacquesCarette JacquesCarette merged commit cce0761 into master Mar 3, 2025
1 check passed
@JacquesCarette JacquesCarette deleted the indexed-products-more-implicits branch March 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants