[Add] Properties for DCPOs in Relation.Binary.Properties.Domain
#2734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmougeot
changed the title
Relation.Binary.Properties.DomainRelation.Binary.Properties.Domain
JacquesCarette
requested changes
Jun 16, 2025
| → (scott : IsScottContinuous P Q f) | ||
| → IsOrderHomomorphism (Poset._≈_ P) (Poset._≈_ Q) (Poset._≤_ P) (Poset._≤_ Q) f | ||
| DirectedCompletePartialOrder+scott→monotone P-DirectedCompletePartialOrder f scott = record | ||
| { cong = λ {x} {y} x≈y → IsScottContinuous.preserveEquality scott x≈y |
There was a problem hiding this comment.
Don't name implicits that you do not use. Try to eta-reduce too.
| → IsOrderHomomorphism (Poset._≈_ P) (Poset._≈_ Q) (Poset._≤_ P) (Poset._≤_ Q) f | ||
| DirectedCompletePartialOrder+scott→monotone P-DirectedCompletePartialOrder f scott = record | ||
| { cong = λ {x} {y} x≈y → IsScottContinuous.preserveEquality scott x≈y | ||
| ; mono = λ {x} {y} x≤y → mono-proof x y x≤y |
There was a problem hiding this comment.
See if you can get away with _ for x and y in the rhs. If so, then make them implicit in the proof below. Otherwise leave a comment about not being able to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces new modules and properties for directed complete partial orders (DCPOs) in the Agda standard library. These additions are adapted from the 1Lab library.
The first part of this pull request is available at [Add] Initial files for Domain theory #2721 .
Please comment only on the
src/Relation/Binary/Properties/Domain.agdafile hereKey Changes:
1. Properties of Least Upper Bounds:
uniqueLub:Proves the uniqueness of least upper bounds.IsLub-cong: Demonstrates congruence of least upper bounds under equivalence.2. Scott Continuity and Monotonicity:
DirectedCompletePartialOrder+scott→monotone: Proves that Scott continuous functions are monotone.3. Scott Continuous Functions:
ScottId: Identity function as a Scott continuous function.scott-∘: Composition of Scott continuous functions.4. Suprema and Pointwise Ordering:
⋃-pointwise: Proves pointwise ordering of suprema in directed families.5. Scott Continuity Module:
pres-⋁: Proves preservation of least upper bounds under Scott continuous functions.6. Conversion to Scott Continuity:
-Added
to-scott: Converts monotone functions with preservation of least upper bounds into Scott continuous functions.Source :
1Lab library