Skip to content

Ring reasoning #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 50 commits into
base: master
Choose a base branch
from
Draft

Ring reasoning #2765

wants to merge 50 commits into from

Conversation

JacquesCarette
Copy link
Contributor

Reasoning combinators for monoid, renamed and adapted for Ring. Builds on #2692 .

jmougeot and others added 30 commits July 3, 2025 15:38
@jmougeot
Adds reasonig combinator for semigroup
4828f10
@jmougeot
Adds reasonig combinator for semigroup
93c9976
@jmougeot
Adds reasonig combinator for semigroup
e885711
@jmougeot
Adds reasonig combinator for semigroup
3c38b3c
@jmougeot
Add some more missing reasoning combinators
cd399f7
@jmougeot
add module Extends
3f79f75
@jmougeot
rename SemiGroup to Semigroup
6b9e442
@jmougeot
fix-whitespace
a3a3181
@jmougeot @jamesmckinna
Update CHANGELOG.md
f8c8533 
Co-authored-by: jamesmckinna <[email protected]>
@jmougeot
New names
19ec1eb
@jmougeot
improve syntx
52eaa44
@jmougeot
fix-whitespace
ee3ac5d
@jmougeot
Name changes
5d47f4c
@jmougeot
Names change
f4c1245
@jmougeot
Space
9f0a376
@jmougeot
Proof of assoc with PUshes and Pulles
3a8d81f
@jmougeot
Proof of assoc with PUshes and Pulles
1c13577
@jmougeot
white space
79311ae
@jmougeot @jamesmckinna
Update src/Algebra/Properties/Semigroup/Reasoning.agda
cc934ca 
Co-authored-by: jamesmckinna <[email protected]>
@jmougeot
Reasoning to Semigroup and explicit variables
17a8964
@jmougeot @jamesmckinna
Update CHANGELOG.md
899099c 
Co-authored-by: jamesmckinna <[email protected]>
@jmougeot
Add reasonining combinators for monoids
4129eed
@jmougeot
chore: move imports around in Algebra.Definitions
0ab87a6 
merge
@jmougeot
Syntax modification
8eb8a69
@jmougeot
rebase
fbf8920
@jmougeot
update semigroup
eb543a8
@jmougeot
One line proof
b742f6f
@jmougeot
move importation
08d797c
@jmougeot
fix-whitespace
490a28c
@jmougeot
Add reasonining combinators for monoids
a34b4b5
jmougeot and others added 17 commits July 3, 2025 15:59
@jmougeot
chore: move imports around in Algebra.Definitions
41696ed 
merge
@jmougeot
Syntax modification
ff966fe
@jmougeot
rebase
3cbb91b 
merge
@jmougeot
move importation
29b22d6
@jmougeot
fix-whitespace
7cd4230
@jmougeot
explicit varaibles
acb6467
@jmougeot
used of semigroup propreties
4b38e08
@jmougeot
update
64d12ad
@JacquesCarette @jamesmckinna @jmougeot
Update CHANGELOG.md
b0179f5 
Co-authored-by: jamesmckinna <[email protected]>
@jmougeot
merge and proof refactoring
dab0763
@jmougeot
Changelog update
7185d5f
@JacquesCarette @jamesmckinna
Update src/Algebra/Properties/Monoid.agda
29add8d 
Co-authored-by: jamesmckinna <[email protected]>
@JacquesCarette @jamesmckinna
Update src/Algebra/Properties/Monoid.agda
9895cef 
Co-authored-by: jamesmckinna <[email protected]>
@JacquesCarette
Update src/Algebra/Properties/Monoid.agda
0e2aee1
@JacquesCarette
rename id to ε
839bca4
@JacquesCarette
Merge branch 'monoid-reasoning' into ring-reasoning
c682582 
Need to build on it.
@JacquesCarette
re-export the reasoning combineators for Monoid for both sub-monoids …
0ba046d 
…of a Ring, properly renamed.
@JacquesCarette JacquesCarette requested a review from Taneb July 12, 2025 16:53
@Taneb
Copy link
Member

Taneb commented Jul 12, 2025

  1. I'd like to see the new semigroup properties here as well
  2. The semigroup properties on * and the monoid properties on + work for RingWithoutOne
  3. In fact, they work on Semiring and SemiringWithoutOne, but we don't have a Properties module for those

@jamesmckinna
Copy link
Contributor

@Taneb 's 1,2,3 above echo my thoughts on looking at these, but maybe, given our ongoing issues regarding naming in #2688 that it isn't so straightforward to back-fill the Properties for weaker structures... yet?

jamesmckinna
jamesmckinna requested changes Jul 13, 2025
View reviewed changes
@JacquesCarette JacquesCarette marked this pull request as draft July 21, 2025 21:12
@JacquesCarette JacquesCarette added this to the v2.4 milestone Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmckinna jamesmckinna jamesmckinna requested changes

@Taneb Taneb Awaiting requested review from Taneb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
addition
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@JacquesCarette @Taneb @jamesmckinna @jmougeot