Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatype of Rationals #109

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Datatype of Rationals #109

merged 3 commits into from
Mar 29, 2019

Conversation

Saizan
Copy link
Contributor

@Saizan Saizan commented Mar 27, 2019

I didn't define any operation, but it's a start if someone wants.

@mortberg
Copy link
Collaborator

Nice! We could also define this as a set quotient and prove that the two representations are equivalent. I don't have any suggestions for improvements, but let's leave it open for a bit if someone else wants to comments.

@riaqn You might want to look at this.

@Alizter
Copy link

Alizter commented Mar 27, 2019

The quotient version is defined as Z x N / ~. Where (a, b) ~ (c, d) iff a(d + 1) = c(b + 1).

@Saizan
Copy link
Contributor Author

Saizan commented Mar 29, 2019

@Alizter do you think that would work better? it seems a bit of an artificial representation trick that would need more messing around with the signs of these interegers, though we won't really know until we implement things.

@Alizter
Copy link

Alizter commented Mar 29, 2019

@Saizan that is the definition of the rationals in the HoTT book, just showing they are equivalent is enough. I like your definition of rationals better however.

@Saizan
Copy link
Contributor Author

Saizan commented Mar 29, 2019

See issue #116

@Saizan Saizan closed this Mar 29, 2019
@Saizan Saizan reopened this Mar 29, 2019
@Saizan Saizan merged commit cc9033c into master Mar 29, 2019
@Saizan Saizan deleted the rationals branch May 7, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants