Adds ktor+netty-based API #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrddunbr
added
enhancement
jrddunbr
commented
Jun 27, 2022
|
|
||
| val circuits = mutableMapOf<UUID, CircuitBundle>() | ||
|
|
||
| fun loadTestCircuits() { |
There was a problem hiding this comment.
This is just the first test from the MNATests.kt file. It doesn't need to be added, it's here for debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP to add a Ktor + Netty API to libage.
Ideally, it would have a few different API endpoints such as:
/- get basic information about the API, perhaps version info for libage/circuits.json/circuit/add- add a circuit/circuit/step- step a circuit (possibly with some more information in the request such as a number of steps/time of steps)/circuit/fetch- get circuit solve values/circuit/delete- delete a circuitThe actual format is not set in stone yet, but there's some ideas floating around. I want to be able to use this from within code primarily, so knowing if there are logical errors and such for error handling would be helpful. eg, singular matrices, invalid connectivity, etc. I also currently catch sim side errors and throw those back with a stack trace but we could disable that for production unless debugging is enabled.