Supabase client is now a singleton #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
dOrgJelli
reviewed
Dec 29, 2023
| if (!this._threads[config.chatId]) { | ||
| this._threads[config.chatId] = new EvoThread(config); | ||
| this._threads[config.chatId] = await EvoThread.load(config); |
There was a problem hiding this comment.
Nice, this is a much better way to handle this.
dOrgJelli
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made supabase client a singleton to prevent the messages below:
When loading chat logs there is a race condition which causes
refechChatsto resolve while still pending.Await EvoThread load helps and reduces the race conditions but they still happen. To prevent this, we now call the fetch method without react query.