This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Remove DB error details from the RPC handler response #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rachit77
approved these changes
Apr 15, 2024
vcastellm
reviewed
Apr 15, 2024
| return "0x0", jRPC.NewRPCError(jRPC.DefaultErrorCode, fmt.Sprintf("failed to execute tx: %s", err)) | ||
| } | ||
|
|
||
| // Send L1 tx | ||
| dbTx, err := i.db.BeginStateTransaction(ctx) | ||
| if err != nil { | ||
| return "0x0", jRPC.NewRPCError(jRPC.DefaultErrorCode, fmt.Sprintf("failed to begin dbTx, error: %s", err)) | ||
| log.Errorf("failed to begin dbTx, error: %s", err) |
There was a problem hiding this comment.
every time it returns here, will log an error, so this is redundant?
There was a problem hiding this comment.
Not necessarily, it returns a short error without details but logs the full error message. It was the main idea of this PR.
vcastellm
reviewed
Apr 15, 2024
| return "0x0", jRPC.NewRPCError(jRPC.DefaultErrorCode, fmt.Sprintf("failed to commit dbTx, error: %s", err)) | ||
|
|
||
| if err = dbTx.Commit(ctx); err != nil { | ||
| log.Errorf("failed to commit dbTx, error: %s", err) |
There was a problem hiding this comment.
every time it returns here, will log an error, so this is redundant?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.