-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the server with the delta sharing client #129
Test the server with the delta sharing client #129
Conversation
In order to run the test (that we run through spark-shell last Friday) I suggest you to create a separate gradle module, make it depend on the app and run the app as a simple jar (https://stackoverflow.com/questions/20728621/running-an-executable-jar-file-built-from-a-gradle-based-project). Then you can write a test using spark (i.e. the test is a spark project), having a class path completely separated from the server one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good first step, I think to complete we need:
- add needed gradle code to start the server before running the test
- add needed gradle code to stop the server at the end of the tests
- run these tests on (a dedicated step of) CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a very good job, a couple of points not pointed out in comments:
- you can generate the http client used in the integration tests starting from the openapi spec, it support java native http client as well (the one you used) that should reduce code duplication and avoid maintenance burden
- you can share a bit more "build side" in this new module (through the internal plugin)
server/src/main/java/io/whitefox/api/deltasharing/DeltaMappers.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/whitefox/api/deltasharing/server/DeltaSharesApiImpl.java
Outdated
Show resolved
Hide resolved
68ae711
to
065171d
Compare
…of task ':client-spark:openapiGenerateClientApi' without declaring an explicit or implicit dependency
wip testing queryTable using a spark-shell with the delta-sharing-spark connector