Catch exception more specifically

agners · May 14, 2024 · 138a686 · 138a686
1 parent b225168
commit 138a686
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/controller/python/test/test_scripts/base.py b/src/controller/python/test/test_scripts/base.py
@@ -41,6 +41,7 @@
 from chip import ChipDeviceCtrl
 from chip.ChipStack import ChipStack
 from chip.crypto import p256keypair
+from chip.exceptions import ChipStackError
 from chip.utils import CommissioningBuildingBlocks
 from cirque_restart_remote_device import restartRemoteDevice
 from ecdsa import NIST256p
@@ -375,7 +376,7 @@ async def TestFailsafe(self, nodeid: int):
             self.logger.error(
                 'Incorrectly succeeded in opening basic commissioning window')
             return False
-        except Exception:
+        except ChipStackError:
             pass
 
         # TODO:
@@ -403,7 +404,7 @@ async def TestFailsafe(self, nodeid: int):
             self.logger.error(
                 'Incorrectly succeeded in opening enhanced commissioning window')
             return False
-        except Exception:
+        except ChipStackError:
             pass
 
         self.logger.info("Disarming failsafe on CASE connection")
@@ -1197,7 +1198,7 @@ class AttributeWriteRequest:
                     if req.expected_status != IM.Status.Success:
                         raise AssertionError(
                             f"Write attribute {req.attribute.__qualname__} expects failure but got success response")
-                except Exception as ex:
+                except ChipStackError as ex:
                     if req.expected_status != IM.Status.Success:
                         continue
                     else: