Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for go1.24 #68

Merged
merged 6 commits into from
Oct 29, 2024
Merged

add support for go1.24 #68

merged 6 commits into from
Oct 29, 2024

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Oct 24, 2024

Closes: #61

agnivade
agnivade requested changes Oct 24, 2024
View reviewed changes
Copy link
Owner

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zxilly, left a small comment.

handler.go Outdated Show resolved Hide resolved
@Zxilly Zxilly changed the title add support for go1.24 and add a fallback for gotoolchain before go1.24 add support for go1.24 Oct 24, 2024
@agnivade agnivade self-requested a review October 24, 2024 15:51
agnivade
agnivade reviewed Oct 29, 2024
View reviewed changes
Copy link
Owner

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay @Zxilly. Thanks for your patience.

handler.go Outdated Show resolved Hide resolved
agnivade
agnivade approved these changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agnivade agnivade merged commit a249c2e into agnivade:master Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnivade agnivade agnivade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to run while using Go Toolchain
2 participants
@Zxilly @agnivade