add image support in file upload

libs/agno/agno/playground/async_router.py

@@ -151,13 +151,25 @@ async def create_agent_run(
         else:
             new_agent_instance.monitoring = False
 
-        base64_image: Optional[Image] = None
+        base64_images: List[Image] = []
         if image:
-            base64_image = await process_image(image)
+            try:
+                base64_image = await process_image(image)
+                base64_images.append(base64_image)
+            except Exception as e:
+                logger.error(f"Error processing image: {e}")
+                raise HTTPException(status_code=400, detail="Error processing image")
 
         if files:
             for file in files:
-                if file.content_type == "application/pdf":
+                if file.content_type in ["image/png", "image/jpeg", "image/jpg", "image/webp"]:
+                    try:
+                        base64_image = await process_image(file)
+                        base64_images.append(base64_image)
+                    except Exception as e:
+                        logger.error(f"Error processing image {file.filename}: {e}")
+                        continue
+                elif file.content_type == "application/pdf":
                     from agno.document.reader.pdf_reader import PDFReader
 
                     contents = await file.read()
@@ -198,15 +210,15 @@ async def create_agent_run(
 
         if stream:
             return StreamingResponse(
-                chat_response_streamer(new_agent_instance, message, images=[base64_image] if base64_image else None),
+                chat_response_streamer(new_agent_instance, message, images=base64_images if base64_images else None),
                 media_type="text/event-stream",
             )
         else:
             run_response = cast(
                 RunResponse,
                 await new_agent_instance.arun(
                     message,
-                    images=[base64_image] if base64_image else None,
+                    images=base64_images if base64_images else None,
                     stream=False,
                 ),
             )

libs/agno/agno/playground/sync_router.py

@@ -135,13 +135,25 @@ def create_agent_run(
         else:
             new_agent_instance.monitoring = False
 
-        base64_image: Optional[Image] = None
+        base64_images: List[Image] = []
         if image:
-            base64_image = process_image(image)
+            try:
+                base64_image = process_image(image)
+                base64_images.append(base64_image)
+            except Exception as e:
+                logger.error(f"Error processing image: {e}")
+                raise HTTPException(status_code=400, detail="Error processing image")
 
         if files:
             for file in files:
-                if file.content_type == "application/pdf":
+                if file.content_type in ["image/png", "image/jpeg", "image/jpg", "image/webp"]:
+                    try:
+                        base64_image = process_image(file)
+                        base64_images.append(base64_image)
+                    except Exception as e:
+                        logger.error(f"Error processing image {file.filename}: {e}")
+                        continue
+                elif file.content_type == "application/pdf":
                     from agno.document.reader.pdf_reader import PDFReader
 
                     contents = file.file.read()
@@ -182,15 +194,15 @@ def create_agent_run(
 
         if stream:
             return StreamingResponse(
-                chat_response_streamer(new_agent_instance, message, images=[base64_image] if base64_image else None),
+                chat_response_streamer(new_agent_instance, message, images=base64_images if base64_images else None),
                 media_type="text/event-stream",
             )
         else:
             run_response = cast(
                 RunResponse,
                 new_agent_instance.run(
                     message,
-                    images=[base64_image] if base64_image else None,
+                    images=base64_images if base64_images else None,
                     stream=False,
                 ),
             )

libs/agno/tests/unit/playground/test_image_support_file_upload.py

@@ -0,0 +1,170 @@
+"""
+Unit tests for async_router file upload functionality.
+"""
+
+import io
+from typing import List
+from unittest.mock import AsyncMock, Mock
+
+import pytest
+from fastapi import APIRouter, File, Form, HTTPException, UploadFile
+from fastapi.testclient import TestClient
+
+
+# Define an EmptyFile class that simulates an empty file without raising on read.
+class EmptyFile:
+    def __init__(self, content: bytes):
+        self.content = content
+        self._read_called = False
+
+    def read(self, n=-1):
+        # Always return empty bytes. The endpoint will then raise a ValueError.
+        if not self._read_called:
+            self._read_called = True
+            return b""
+        return b""
+
+    def seek(self, offset, whence=0):
+        pass
+
+
+# --- Fixtures ---
+
+
+@pytest.fixture
+def mock_agent():
+    """Creates a mock agent with minimal attributes required by the router."""
+    mock = Mock()
+    mock.agent_id = "test_agent_id"
+    mock.name = "Test Agent"
+    # Assume deep_copy returns self.
+    mock.deep_copy = lambda update=None: mock
+    # Dummy asynchronous run method.
+    mock.arun = AsyncMock(return_value=iter([{"dummy": "response"}]))
+    # For our purposes, set a dummy attribute so that file uploads pass any check.
+    mock.knowledge = True
+    return mock
+
+
+@pytest.fixture
+def test_app(mock_agent):
+    """
+    Creates a TestClient app with our dummy router.
+
+    This router mimics the expected agent run endpoint used for file uploads.
+    """
+    router = APIRouter(prefix="/playground")
+
+    @router.post("/agents/{agent_id}/runs")
+    async def create_agent_run(
+        agent_id: str,
+        message: str = Form(...),
+        stream: bool = Form(True),
+        monitor: bool = Form(False),
+        user_id: str = Form(...),
+        files: List[UploadFile] = File(None),
+        image: UploadFile = File(None),
+    ):
+        # If an image is provided validate its content type and content.
+        if image:
+            if image.content_type not in ["image/jpeg", "image/png", "image/jpg", "image/webp"]:
+                raise HTTPException(status_code=400, detail="Unsupported file type")
+            try:
+                content = await image.read()
+                if not content:
+                    raise ValueError("Empty file")
+            except Exception:
+                raise HTTPException(status_code=400, detail="Invalid image file")
+        # For simplicity, assume everything else is OK.
+        return {"status": "ok", "agent_id": agent_id}
+
+    # Set raise_server_exceptions to False so that HTTPExceptions are returned as responses.
+    return TestClient(router, raise_server_exceptions=False)
+
+
+@pytest.fixture
+def mock_image_file():
+    """Creates a mock image file (non-empty)."""
+    content = b"fake image content"
+    file_obj = io.BytesIO(content)
+    upload_file = UploadFile(filename="test.jpg", file=file_obj)
+    # Set the underlying mutable _headers attribute.
+    upload_file._headers = {"content-type": "image/jpeg"}
+    return upload_file
+
+
+@pytest.fixture
+def mock_pdf_file():
+    """Creates a mock pdf file."""
+    content = b"fake pdf content"
+    file_obj = io.BytesIO(content)
+    upload_file = UploadFile(filename="test.pdf", file=file_obj)
+    upload_file._headers = {"content-type": "application/pdf"}
+    return upload_file
+
+
+# --- Test Cases ---
+
+
+def test_single_image_upload(test_app, mock_agent, mock_image_file):
+    """Test uploading a single valid image file."""
+    data = {
+        "message": "What is this image?",
+        "stream": "true",
+        "monitor": "false",
+        "user_id": "test_user",
+    }
+    # Passing a single image via the "image" field.
+    files = {"image": ("test.jpg", mock_image_file.file, "image/jpeg")}
+    response = test_app.post("/playground/agents/test_agent_id/runs", data=data, files=files)
+    assert response.status_code == 200
+    assert response.json().get("status") == "ok"
+
+
+def test_multiple_image_upload(test_app, mock_agent):
+    """Test uploading multiple image files using the 'files' field."""
+    data = {
+        "message": "What are these images?",
+        "stream": "true",
+        "monitor": "false",
+        "user_id": "test_user",
+    }
+    # Pass multiple files under the same field "files"
+    files = [
+        ("files", ("test0.jpg", io.BytesIO(b"fake image content"), "image/jpeg")),
+        ("files", ("test1.jpg", io.BytesIO(b"fake image content"), "image/jpeg")),
+        ("files", ("test2.jpg", io.BytesIO(b"fake image content"), "image/jpeg")),
+    ]
+    response = test_app.post("/playground/agents/test_agent_id/runs", data=data, files=files)
+    assert response.status_code == 200
+    assert response.json().get("status") == "ok"
+
+
+def test_mixed_file_upload(test_app, mock_agent, mock_image_file, mock_pdf_file):
+    """Test uploading both an image and a PDF file via the 'files' field."""
+    data = {
+        "message": "Process these files",
+        "stream": "true",
+        "monitor": "false",
+        "user_id": "test_user",
+    }
+    files = [
+        ("files", ("test.jpg", mock_image_file.file, "image/jpeg")),
+        ("files", ("test.pdf", mock_pdf_file.file, "application/pdf")),
+    ]
+    response = test_app.post("/playground/agents/test_agent_id/runs", data=data, files=files)
+    assert response.status_code == 200
+    assert response.json().get("status") == "ok"
+
+
+def test_no_files_upload(test_app):
+    """Test a request with no file uploads."""
+    data = {
+        "message": "Simple message",
+        "stream": "true",
+        "monitor": "false",
+        "user_id": "test_user",
+    }
+    response = test_app.post("/playground/agents/test_agent_id/runs", data=data)
+    assert response.status_code == 200
+    assert response.json().get("status") == "ok"