Address Issues that can be addressed via README changes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lemon-gith
commented
May 11, 2024
lemon-gith
commented
- Issue Error is README.md #12: just swapping out "O" for "0" to make it a valid hex string
- Issue NOT CROCKFORD COMPATIBLE #23: making it clear that this is a similar encoding to Crockford, but is not the same
- Issue different encoding result #25: forgoing all ambiguity on what the encoding might be, by explicitly documenting the encoding table (open to aesthetic changes)
- Added the detail that ending batches of < 5 bits are zero-padded, just as a bonus
|
Hi @lemon-gith ! Thanks for the contribution, it looks good to me! |
agnoster
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.