chore: change DecodeLog signature to ensure topics are always 32 bytes

agnosticeng · Jan 29, 2025 · 4c2b4d0 · 4c2b4d0
1 parent 43a7758
commit 4c2b4d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/encoding/json/decode_log.go b/encoding/json/decode_log.go
@@ -7,7 +7,7 @@ import (
 	eth_abi "github.com/ethereum/go-ethereum/accounts/abi"
 )
 
-func DecodeLog(topics [][]byte, input []byte, event eth_abi.Event) (ast.Node, error) {
+func DecodeLog(topics [][32]byte, input []byte, event eth_abi.Event) (ast.Node, error) {
 	var indexed, unindexed = SplitInputs(event.Inputs)
 
 	// mismatch btw num of indexed fields and num of topics
@@ -37,7 +37,7 @@ func DecodeLog(topics [][]byte, input []byte, event eth_abi.Event) (ast.Node, er
 	}
 
 	for i, input := range indexed {
-		v, err := DecodeValue(topics[i+1], input.Type)
+		v, err := DecodeValue(topics[i+1][:], input.Type)
 
 		if err != nil {
 			return ast.Node{}, err

diff --git a/encoding/json/decode_test.go b/encoding/json/decode_test.go
@@ -75,7 +75,7 @@ func TestDecodeLog(t *testing.T) {
 			var (
 				event  = _abi.Events[log.EventName]
 				input  = hexutil.MustDecode(log.Input)
-				topics = lo.Map(log.Topics, func(topic string, _ int) []byte { return hexutil.MustDecode(topic) })
+				topics = lo.Map(log.Topics, func(topic string, _ int) [32]byte { return [32]byte(hexutil.MustDecode(topic)) })
 			)
 
 			node, err := DecodeLog(topics, input, event)