ISSUE-158&159

src/Agoda.Analyzers.Test/Agoda.Analyzers.Test.csproj

@@ -31,6 +31,7 @@
     <ProjectReference Include="..\Agoda.Analyzers\Agoda.Analyzers.csproj" />
   </ItemGroup>
   <ItemGroup>
+    <PackageReference Include="FluentAssertions" Version="5.10.3" />
     <PackageReference Include="Microsoft.AspNet.Mvc" Version="5.2.3" />
     <PackageReference Include="Microsoft.AspNet.Razor" Version="3.2.3" />
     <PackageReference Include="Microsoft.AspNet.WebPages" Version="3.2.3" />

src/Agoda.Analyzers.Test/AgodaCustom/AG0012UnitTests.cs

@@ -184,5 +184,40 @@ void helper(int i)
 
             await VerifyDiagnosticsAsync(code, EmptyDiagnosticResults);
         }
+
+        [Test]
+        public async Task AG0012_WithFluentAssertions_ShouldNotShowWarning()
+        {
+            var code = new CodeDescriptor
+            {
+                References = new[] { typeof(TestFixtureAttribute).Assembly, typeof(FluentAssertions.NumericAssertionsExtensions).Assembly },
+                Code = @"
+                    using NUnit.Framework;
+                    using FluentAssertions;
+                    using System;
+                    
+                    namespace Tests
+                    {
+                        public class TestClass
+                        {
+                            [Test]
+                            public void This_Is_Valid()
+                            {
+                                int[] arrayForShouldBe = { 1, 2, 3 };
+                                arrayForShouldBe.Length.Should().Be(3);
+                            }
+                    
+                            [Test]
+                            public void This_Is_AlsoValid()
+                            {
+                                var act = () => var y = 1;
+                                act.Should().Throw<Exception>();
+                            }
+                        }
+                    }"
+            };
+
+            await VerifyDiagnosticsAsync(code, EmptyDiagnosticResults);
+        }
     }
 }

src/Agoda.Analyzers/AgodaCustom/AG0012TestMethodMustContainAtLeastOneAssertion.cs

@@ -43,6 +43,7 @@ private static readonly LocalizableString Description
         {
             new AssertLibraryInfo("NUnit.Framework", "nunit.framework.dll", "Assert"),
             new AssertLibraryInfo("Shouldly", "Shouldly.dll", "Should", "Shouldly.Should"),
+            new AssertLibraryInfo("FluentAssertions", "FluentAssertions.dll", "Should", "FluentAssertions.NumericAssertionsExtensions"),
         };
 
         public override void Initialize(AnalysisContext context)

src/Agoda.Analyzers/AgodaCustom/CustomRulesResources.resx

@@ -201,7 +201,7 @@
     <value>Ensure that publicly exposed IEnumerable types</value>
   </data>
   <data name="AG0026Title" xml:space="preserve">
-    <value>Use only CSS Selectors to find elements in Selenium tests</value>
+    <value>Use only CSS Selectors to find elements in Selenium tests (preferrably use [data-selenium] attributes)</value>
   </data>
   <data name="AG0010Title" xml:space="preserve">
     <value>Prevent test fixture inheritance</value>