Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fixing some clippy warnings #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

enaut
Copy link

@enaut enaut commented Dec 9, 2023

Updated the dependency to nom 7

Fixed some clippy warnings mostly:

  • redundant code (closures that only call one function can be the function instead)
  • complex types, solved by introducing type aliases

@enaut
Copy link
Author

enaut commented Dec 12, 2023

Ouch now I pushed some extra commits to that branch... Take a close look at the last two commits... If you really want thiserror as a dependency I can redo the PR without if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant