Skip to content

Commit

Permalink
Fix CI issues - Upgrade actions/upload-artifact & actions/download-ar…
Browse files Browse the repository at this point in the history
…tifact to v4 and set min version for packaging (astronomer#1208)

I am observing that our CI
[jobs](https://github.com/astronomer/astronomer-cosmos/actions/runs/10920015707/job/30308959677?pr=1207)
are failing complaining that we're using deprecated version (v2) for
`actions/upload-artifact` & `actions/download-artifact`. It is weird
that the jobs directly are failed for using deprecating versions, but so
is the case that's happening. Hence, to get the CI working I'm upgrading
the versions to use v4.

Additionally, we are observing failures for packaging version as
discussed in
astronomer#1201 (comment).
Hence, also set the min packaging version to `22.0` as per the
discussion in that thread

closes: astronomer#1209

---------

Co-authored-by: Tatiana Al-Chueyr <[email protected]>
  • Loading branch information
2 people authored and ags-de committed Sep 24, 2024
1 parent 1539bb2 commit 3c24536
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
hatch run tests.py${{ matrix.python-version }}-${{ matrix.airflow-version }}:test-cov
- name: Upload coverage to Github
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-unit-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
Expand Down Expand Up @@ -177,7 +177,7 @@ jobs:
POSTGRES_PORT: 5432

- name: Upload coverage to Github
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-integration-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
Expand Down Expand Up @@ -248,7 +248,7 @@ jobs:
POSTGRES_PORT: 5432

- name: Upload coverage to Github
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-integration-expensive-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
Expand Down Expand Up @@ -315,7 +315,7 @@ jobs:
POSTGRES_PORT: 5432

- name: Upload coverage to Github
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-integration-sqlite-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
Expand Down Expand Up @@ -391,7 +391,7 @@ jobs:
POSTGRES_PORT: 5432

- name: Upload coverage to Github
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-integration-dbt-1-5-4-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
Expand Down Expand Up @@ -534,7 +534,7 @@ jobs:
POSTGRES_PORT: 5432

- name: Upload coverage to Github
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-integration-kubernetes-test-${{ matrix.python-version }}-${{ matrix.airflow-version }}
path: .coverage
Expand All @@ -559,7 +559,7 @@ jobs:
run: |
pip3 install coverage
- name: Download all coverage artifacts
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
path: ./coverage
- name: Combine coverage
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies = [
"importlib-metadata; python_version < '3.8'",
"Jinja2>=3.0.0",
"msgpack",
"packaging",
"packaging>=22.0",
"pydantic>=1.10.0",
"typing-extensions; python_version < '3.8'",
"virtualenv",
Expand Down Expand Up @@ -86,7 +86,7 @@ docs = [
"apache-airflow-providers-cncf-kubernetes>=5.1.1",
]
tests = [
"packaging",
"packaging>=22.0",
"pytest>=6.0",
"pytest-split",
"pytest-dotenv",
Expand Down

0 comments on commit 3c24536

Please sign in to comment.