tests and coveralls cover

.coveralls.yml

@@ -0,0 +1,2 @@
+service_name: travis-ci
+repo_token: o73BiIANdR3JrQaeIEgfPilPmBufxLQUb

README.md

@@ -1,10 +1,11 @@
 # ONVIF
 
 [![Build Status](https://travis-ci.org/agsh/onvif.png)](https://travis-ci.org/agsh/onvif)
+[![Coverage Status](https://img.shields.io/coveralls/agsh/onvif.svg)](https://coveralls.io/r/agsh/onvif?branch=master)
 
 ONVIF Node.js implementation based on this [article](http://ltoscanolm.hubpages.com/hub/onvif-programming-revealed).
 
-![ONVIF](http://www.onvif.org/Portals/_default/Skins/onvif/images/logo-new.jpg)
+[![ONVIF](http://www.onvif.org/Portals/_default/Skins/onvif/images/logo-new.jpg)](http://onvif.org)
 
 ##Supported methods
 * GetSystemDateAndTime
@@ -74,4 +75,7 @@ Returns an object with camera DateTime
 
 And with credentials (with passed `username` and `password` in object):
 
-### getVideoSources
+### getServices(callback)
+Returns in callback and assigns to #services property an array consists of objects with properties: `namespace`, `XAddr`, `version`
+
+

lib/onvif.js

@@ -194,6 +194,7 @@ Cam.prototype.getVideoSources = function(callback) {
 
 /**
  * Get active sources
+ * @private
  */
 Cam.prototype.getActiveSources = function() {
 	if (this.videoSources.$) { // NVT is a camera
@@ -243,7 +244,6 @@ Cam.prototype.getProfiles = function(callback) {
 			this.defaultProfile = this.profiles[0]; // setting up default profile
 		}
 		if (callback) {
-			//TODO rewrite profiles storing
 			callback(null, this.profiles);
 		}
 	}.bind(this));
@@ -262,7 +262,7 @@ Cam.prototype.getServices = function(callback) {
 		if (err) {
 			return callback ? callback(err) : null;
 		}
-		this.services = _linerase(data);
+		this.services = _linerase(data).getServicesResponse.service;
 		if (callback) {
 			callback(null, this.services);
 		}
@@ -502,20 +502,20 @@ var _linerase = exports._linerase = function _linerase(xml) {
 module.exports.Cam = Cam;
 
 //var cam = new Cam({hostname: 'localhost', port: 10101, username: 'admin', password: '9999'}, function(err) {
-var cam = new Cam({hostname: '192.168.68.111', username: 'admin', password: '9999'}, function(err) {
+/*var cam = new Cam({hostname: '192.168.68.111', username: 'admin', password: '9999'}, function(err) {
 	if (err) {
 		return console.log(err);
 	}
 	console.log(JSON.stringify(this));
-	this.getSystemDateAndTime(console.log);
+	this.getServices(function(err,d){console.log(JSON.stringify(d))});
 	//console.log(this.ptzUri);
 	//this.getProfiles(function(err,d){console.log(JSON.stringify(d));});
 });
-/*cam.on('rawResponse', function(data) {
+cam.on('rawResponse', function(data) {
 	console.log(data);
 });*/
 
-/*var cam = new Cam({hostname: '192.168.68.111', username: 'admin', password: '9999'}, function(err) {
+var cam = new Cam({hostname: '192.168.68.111', username: 'admin', password: '9999'}, function(err) {
 	if (err) {
 		return console.log(err);
 	}
@@ -531,4 +531,4 @@ var cam = new Cam({hostname: '192.168.68.111', username: 'admin', password: '999
 			, zoom: 1
 		});
 	}.bind(this), 5000);
-});*/
+});

package.json

@@ -13,11 +13,15 @@
   },
   "dependencies": {
     "async": ">=0.9.0",
+    "coveralls": "^2.11.2",
+    "mocha-lcov-reporter": "0.0.1",
     "xml2js": ">=0.4.4"
   },
   "keywords": [
     "onvif",
-    "video"
+    "video",
+    "PTZ",
+    "camera"
   ],
   "license": "MIT",
   "engines": {
@@ -26,4 +30,4 @@
   "devDependencies": {
     "mocha": ">=2.1.0"
   }
-}
+}

test/simple.coffee

@@ -12,8 +12,20 @@ describe 'Simple and common get functions', () ->
       , port: 10101
     }, done
 
+  #describe 'object '
+
   describe 'getSystemDateAndTime', () ->
     it 'should return valid date', (done) ->
       cam.getSystemDateAndTime (err, data) ->
+        assert.equal err, null
         assert.ok (data instanceof Date)
         done()
+
+  describe 'getServices', () ->
+    it 'should return an array of services objects', (done) ->
+      cam.getServices (err, data) ->
+        assert.equal err, null
+        assert.ok Array.isArray data
+        assert.ok data.every (service) ->
+          service.namespace and service.XAddr and service.version
+        done()

test/simple.map

@@ -6,5 +6,5 @@
     "simple.coffee"
   ],
   "names": [],
-  "mappings": ";AAAA;AAAA,MAAA,yBAAA;;AAAA,EAAA,MAAA,GAAS,OAAA,CAAQ,QAAR,CAAT,CAAA;;AAAA,EACA,GAAA,GAAM,OAAA,CAAQ,cAAR,CAAuB,CAAC,GAD9B,CAAA;;AAAA,EAEA,YAAA,GAAe,OAAA,CAAQ,gBAAR,CAFf,CAAA;;AAAA,EAIA,QAAA,CAAS,iCAAT,EAA4C,SAAA,GAAA;AAC1C,QAAA,GAAA;AAAA,IAAA,GAAA,GAAM,IAAN,CAAA;AAAA,IACA,MAAA,CAAO,SAAC,IAAD,GAAA;aACL,GAAA,GAAU,IAAA,GAAA,CAAI;AAAA,QACZ,QAAA,EAAU,WADE;AAAA,QAEV,QAAA,EAAU,OAFA;AAAA,QAGV,QAAA,EAAU,MAHA;AAAA,QAIV,IAAA,EAAM,KAJI;OAAJ,EAKP,IALO,EADL;IAAA,CAAP,CADA,CAAA;WASA,QAAA,CAAS,sBAAT,EAAiC,SAAA,GAAA;aAC/B,EAAA,CAAG,0BAAH,EAA+B,SAAC,IAAD,GAAA;eAC7B,GAAG,CAAC,oBAAJ,CAAyB,SAAC,GAAD,EAAM,IAAN,GAAA;AACvB,UAAA,MAAM,CAAC,EAAP,CAAW,IAAA,YAAgB,IAA3B,CAAA,CAAA;iBACA,IAAA,CAAA,EAFuB;QAAA,CAAzB,EAD6B;MAAA,CAA/B,EAD+B;IAAA,CAAjC,EAV0C;EAAA,CAA5C,CAJA,CAAA;AAAA"
+  "mappings": ";AAAA;AAAA,MAAA,yBAAA;;AAAA,EAAA,MAAA,GAAS,OAAA,CAAQ,QAAR,CAAT,CAAA;;AAAA,EACA,GAAA,GAAM,OAAA,CAAQ,cAAR,CAAuB,CAAC,GAD9B,CAAA;;AAAA,EAEA,YAAA,GAAe,OAAA,CAAQ,gBAAR,CAFf,CAAA;;AAAA,EAIA,QAAA,CAAS,iCAAT,EAA4C,SAAA,GAAA;AAC1C,QAAA,GAAA;AAAA,IAAA,GAAA,GAAM,IAAN,CAAA;AAAA,IACA,MAAA,CAAO,SAAC,IAAD,GAAA;aACL,GAAA,GAAU,IAAA,GAAA,CAAI;AAAA,QACZ,QAAA,EAAU,WADE;AAAA,QAEV,QAAA,EAAU,OAFA;AAAA,QAGV,QAAA,EAAU,MAHA;AAAA,QAIV,IAAA,EAAM,KAJI;OAAJ,EAKP,IALO,EADL;IAAA,CAAP,CADA,CAAA;AAAA,IAWA,QAAA,CAAS,sBAAT,EAAiC,SAAA,GAAA;aAC/B,EAAA,CAAG,0BAAH,EAA+B,SAAC,IAAD,GAAA;eAC7B,GAAG,CAAC,oBAAJ,CAAyB,SAAC,GAAD,EAAM,IAAN,GAAA;AACvB,UAAA,MAAM,CAAC,KAAP,CAAa,GAAb,EAAkB,IAAlB,CAAA,CAAA;AAAA,UACA,MAAM,CAAC,EAAP,CAAW,IAAA,YAAgB,IAA3B,CADA,CAAA;iBAEA,IAAA,CAAA,EAHuB;QAAA,CAAzB,EAD6B;MAAA,CAA/B,EAD+B;IAAA,CAAjC,CAXA,CAAA;WAkBA,QAAA,CAAS,aAAT,EAAwB,SAAA,GAAA;aACtB,EAAA,CAAG,4CAAH,EAAiD,SAAC,IAAD,GAAA;eAC/C,GAAG,CAAC,WAAJ,CAAgB,SAAC,GAAD,EAAM,IAAN,GAAA;AACd,UAAA,MAAM,CAAC,KAAP,CAAa,GAAb,EAAkB,IAAlB,CAAA,CAAA;AAAA,UACA,MAAM,CAAC,EAAP,CAAU,KAAK,CAAC,OAAN,CAAc,IAAd,CAAV,CADA,CAAA;AAAA,UAEA,MAAM,CAAC,EAAP,CAAU,IAAI,CAAC,KAAL,CAAW,SAAC,OAAD,GAAA;mBACnB,OAAO,CAAC,SAAR,IAAsB,OAAO,CAAC,KAA9B,IAAwC,OAAO,CAAC,QAD7B;UAAA,CAAX,CAAV,CAFA,CAAA;iBAIA,IAAA,CAAA,EALc;QAAA,CAAhB,EAD+C;MAAA,CAAjD,EADsB;IAAA,CAAxB,EAnB0C;EAAA,CAA5C,CAJA,CAAA;AAAA"
 }