feat(onvif-events): Restart event requests after ECONNRESET error #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agsh
force-pushed
the
feat-restart-event-request-after-connection-error
branch
from
f865285 to
e1dbc71
Compare
Deploying onvif with
|
| Latest commit: |
d04eae0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://792d14f7.onvif.pages.dev |
| Branch Preview URL: | https://feat-restart-event-request-a.onvif.pages.dev |
agsh
force-pushed
the
feat-restart-event-request-after-connection-error
branch
from
e1dbc71 to
7903189
Compare
…t-after-connection-error retry on other error codes and sets max retry delay
|
Yep that is looking good to me and is reconnecting to my doorbell after a restart. Ill get an MR into Shinobi once the new version is available. Thanks for your help with this! |
|
@HarryEMartland You're welcome! 😉 Release is ready: https://github.com/agsh/onvif/actions/runs/9150337468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compilation, refactoring and tests for two PRs about reconnecting if the connection to the device fails: #314 #319