Merge pull request #33 from aguingand/improve-parse-perf

Improve parse performance
aguingand · Jul 22, 2023 · 388604b · 388604b
2 parents 3f6f8c2 + 2a39cf2
commit 388604b
Show file tree

Hide file tree

Showing 6 changed files with 93 additions and 14 deletions.
diff --git a/example/src/components/Editor.vue b/example/src/components/Editor.vue
@@ -32,7 +32,8 @@
     import CodeBlock from "@tiptap/extension-code-block";
     import { Markdown } from "tiptap-markdown";
     import MenuBar from "./MenuBar.vue";
-    import content from '../content.md?raw';
+    import content from '../data/content.md?raw';
+    // import content from "../data/large-content";
     import Highlight from "../extensions/highlight";
     import Container from "../extensions/container";
 

diff --git a/example/src/content.md → example/src/data/content.md b/example/src/content.md → example/src/data/content.md
diff --git a/example/src/data/large-content.js b/example/src/data/large-content.js
diff --git a/src/Markdown.js b/src/Markdown.js
@@ -41,7 +41,7 @@ export const Markdown = Extension.create({
     onBeforeCreate() {
         this.editor.storage.markdown = {
             options: { ...this.options },
-            parser: new MarkdownParser(this.editor),
+            parser: new MarkdownParser(this.editor, this.options),
             serializer: new MarkdownSerializer(this.editor),
             getMarkdown: () => {
                 return this.editor.storage.markdown.serializer.serialize(this.editor.state.doc);

diff --git a/src/parse/MarkdownParser.js b/src/parse/MarkdownParser.js
@@ -8,24 +8,23 @@ export class MarkdownParser {
      * @type {import('@tiptap/core').Editor}
      */
     editor = null;
+    /**
+     * @type {markdownit}
+     */
+    md = null;
 
-    constructor(editor) {
+    constructor(editor, { html, linkify, breaks }) {
         this.editor = editor;
-    }
-
-    parse(content, { inline } = {}) {
-        const {
+        this.md = markdownit({
             html,
             linkify,
             breaks,
-        } = this.editor.storage.markdown.options;
+        });
+    }
 
+    parse(content, { inline } = {}) {
         if(typeof content === 'string') {
-            const renderer = markdownit({
-                html,
-                linkify,
-                breaks,
-            });
+            const renderer = this.md;
 
             this.editor.extensionManager.extensions.forEach(extension =>
                 getMarkdownSpec(extension)?.parse?.setup?.call({ editor:this.editor, options:extension.options }, renderer)

diff --git a/src/util/markdown.js b/src/util/markdown.js
@@ -1,8 +1,10 @@
 import markdownit from 'markdown-it';
 
+const md = markdownit();
 
 function scanDelims(text, pos) {
-    const state = new (markdownit().inline.State)(text, null, null, []);
+    md.inline.State.prototype.scanDelims.call({ src: text, posMax: text.length })
+    const state = new (md.inline.State)(text, null, null, []);
     return state.scanDelims(pos, true);
 }