♻️ 이미 등록된 즐겨찾기 역 정보와 등록하고자 하는 역 정보가 동일할 때 예외 처리 (#339)

application/src/main/kotlin/backend/team/ahachul_backend/api/member/application/service/MemberService.kt

@@ -15,6 +15,8 @@ import backend.team.ahachul_backend.api.member.application.port.out.MemberStatio
 import backend.team.ahachul_backend.api.member.application.port.out.MemberStationWriter
 import backend.team.ahachul_backend.api.member.domain.entity.MemberEntity
 import backend.team.ahachul_backend.api.member.domain.entity.MemberStationEntity
+import backend.team.ahachul_backend.common.exception.CommonException
+import backend.team.ahachul_backend.common.response.ResponseCode
 import backend.team.ahachul_backend.common.utils.RequestUtils
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
@@ -59,6 +61,10 @@ class MemberService(
         val bookmarkStations = command.stations
         val originMemberStations = memberStationReader.getByMember(member)
 
+        if (isAlreadyRegisteredStation(originMemberStations, bookmarkStations)) {
+            throw CommonException(ResponseCode.ALREADY_REGISTERED_STATION)
+        }
+
         if (originMemberStations.isNotEmpty()) {
             memberStationWriter.deleteAllByMember(member)
         }
@@ -67,18 +73,6 @@ class MemberService(
         return BookmarkStationDto.Response(bookmarkStationIds)
     }
 
-    private fun saveNewStations(member: MemberEntity, bookmarkStations: List<BookmarkStationCommand>): List<Long> {
-        return bookmarkStations
-            .map {
-                val memberStation = MemberStationEntity(
-                    member = member,
-                    station = stationReader.getByName(it.stationName),
-                    label = it.label
-                )
-                memberStationWriter.save(memberStation).id
-            }
-    }
-
     override fun getBookmarkStation(): GetBookmarkStationDto.Response {
         val member = memberReader.getMember(RequestUtils.getAttribute("memberId")!!.toLong())
 
@@ -108,6 +102,31 @@ class MemberService(
         return SearchMemberDto.Response.of(members)
     }
 
+    private fun isAlreadyRegisteredStation(
+        originMemberStations: List<MemberStationEntity>,
+        bookmarkStations: List<BookmarkStationCommand>
+    ): Boolean {
+        if (originMemberStations.size != bookmarkStations.size) {
+            return false
+        }
+
+        return originMemberStations.indices.all {
+            originMemberStations[it].isEquals(bookmarkStations[it].stationName, bookmarkStations[it].label)
+        }
+    }
+
+    private fun saveNewStations(member: MemberEntity, bookmarkStations: List<BookmarkStationCommand>): List<Long> {
+        return bookmarkStations
+            .map {
+                val memberStation = MemberStationEntity(
+                    member = member,
+                    station = stationReader.getByName(it.stationName),
+                    label = it.label
+                )
+                memberStationWriter.save(memberStation).id
+            }
+    }
+
     private fun getSubwayLineInfos(station: StationEntity): List<GetBookmarkStationDto.SubwayLineInfo> {
         val subwayLineStations = subwayLineStationReader.findByStation(station)
         return subwayLineStations.map {

application/src/test/kotlin/backend/team/ahachul_backend/api/member/application/service/MemberServiceTest.kt

@@ -21,6 +21,7 @@ import backend.team.ahachul_backend.api.member.domain.model.ProviderType
 import backend.team.ahachul_backend.common.domain.entity.SubwayLineEntity
 import backend.team.ahachul_backend.common.domain.model.RegionType
 import backend.team.ahachul_backend.common.exception.BusinessException
+import backend.team.ahachul_backend.common.exception.CommonException
 import backend.team.ahachul_backend.common.persistence.SubwayLineRepository
 import backend.team.ahachul_backend.common.response.ResponseCode
 import backend.team.ahachul_backend.common.utils.RequestUtils
@@ -261,6 +262,41 @@ class MemberServiceTest(
             )
     }
 
+    @Test
+    fun 이미_등록된_즐겨찾기_역_정보와_동일한_정보로_수정_요청하지_못한다() {
+        // given
+        val station1 = StationEntity(name = "시청역")
+        val station2 = StationEntity(name = "강남역")
+
+        stationRepository.saveAll(listOf(station1, station2))
+
+        val memberStation1 = MemberStationEntity(
+            member = member!!,
+            station = station1,
+            label = "집"
+        )
+
+        val memberStation2 = MemberStationEntity(
+            member = member!!,
+            station = station2,
+            label = "직장"
+        )
+
+        memberStationRepository.saveAll(listOf(memberStation1, memberStation2))
+
+        val command = BookmarkStationCommands(
+            stations = listOf(
+                BookmarkStationCommand("시청역", "집"),
+                BookmarkStationCommand("강남역", "직장"),
+            )
+        )
+
+        // when & then
+        assertThatThrownBy { memberUseCase.bookmarkStation(command) }
+            .isExactlyInstanceOf(CommonException::class.java)
+            .hasMessage("이미 등록된 즐겨찾기 역 정보와 동일합니다.")
+    }
+
     @Test
     fun 즐겨찾는_역이_4개_보다_크면_실패() {
         // when + then

core/src/main/kotlin/backend/team/ahachul_backend/api/member/domain/entity/MemberStationEntity.kt

@@ -23,4 +23,8 @@ class MemberStationEntity(
     val station: StationEntity
 
 ): BaseEntity() {
+
+    fun isEquals(stationName: String, label: String?) : Boolean {
+        return this.station.name == stationName && this.label == label
+    }
 }

core/src/main/kotlin/backend/team/ahachul_backend/common/response/ResponseCode.kt

@@ -53,7 +53,8 @@ enum class ResponseCode(
     FAILED_TO_GET_CONGESTION_INFO("705", "현재 혼잡도 정보를 받을 수 없습니다.", HttpStatus.NOT_FOUND),
 
     // STATION
-    EXCEED_MAXIMUM_STATION_COUNT("800", "즐겨찾는 역은 최대 3개까지 가능합니다.", HttpStatus.BAD_REQUEST),
+    EXCEED_MAXIMUM_STATION_COUNT("800", "즐겨찾는 역은 최대 4개까지 가능합니다.", HttpStatus.BAD_REQUEST),
+    ALREADY_REGISTERED_STATION("801", "이미 등록된 즐겨찾기 역 정보와 동일합니다.", HttpStatus.BAD_REQUEST),
 
     // FILE
     FILE_READ_FAILED("800", "파일 읽기에 실패했습니다.", HttpStatus.INTERNAL_SERVER_ERROR);