Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ 크롤링 환경 도커 이미지로 세팅 (#305) #334

Merged
merged 41 commits into from
Feb 17, 2025

Conversation

semi-cloud
Copy link
Collaborator

@semi-cloud semi-cloud commented Feb 15, 2025

📚 개요

✏️ 작업 내용

  1. 직접 서버에 크롤링 환경을 세팅해주지 않고 도커 컨테이너로 실행시키도록 수정했습니다.
    • CI 수정, CD 스크립트(batch-server의 /usr/local/bin/deploy-script.sh 위치)에서 도커 볼륨 생성해서 실행 시 크롤링 데이터를 스프링 컨테이너에서 접근할 수 있도록 했습니다.
     docker run -v ahachul-data:/app/ahachul_data/datas -d --name batch-dev-container -p 8080:8080 {...}/ahhachul-dev-batch/app
    
     docker run -v ahachul-data:/app/ahachul_data/datas -d --name batch-dev-cron-container  {...}/cron
    
  2. 서로 독립적으로 빌드하기 위해 스케줄러 컨테이너랑 크론 컨테이너 워크플로우를 분리했습니다.
  3. 배포 스크립트에서 새롭게 빌드한 이미지가 있을 때만 기존 컨테이너 중지시키고 실행하도록 수정했습니다.

💡 주의 사항

  • 추후에 크롤링 환경 세팅할때도 참고해서 하시면 될 것 같아요! (cc. @discphy)

@semi-cloud semi-cloud requested review from hwgyun and discphy February 15, 2025 07:24
@semi-cloud semi-cloud self-assigned this Feb 15, 2025
Copy link

github-actions bot commented Feb 15, 2025

Unit Test Results

140 tests   140 ✔️  9s ⏱️
  32 suites      0 💤
  32 files        0

Results for commit 6ce7a2b.

♻️ This comment has been updated with latest results.

@semi-cloud semi-cloud marked this pull request as ready for review February 15, 2025 08:45
Copy link
Member

@discphy discphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 코멘트 드린 부분만 확인 부탁드립니다!

@semi-cloud semi-cloud requested a review from discphy February 17, 2025 14:50
@semi-cloud semi-cloud merged commit 7ab75dc into develop Feb 17, 2025
2 checks passed
@semi-cloud semi-cloud deleted the feature/305 branch February 17, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants