Skip to content

Commit

Permalink
libgc make check test passes
Browse files Browse the repository at this point in the history
with -fexceptions support, all the tests appear to pass.
sometimes the gctest check takes a bit on aarch64 on QEMU.
  • Loading branch information
ahgamut committed Sep 23, 2024
1 parent 399effd commit eb5fd41
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions lib/libgc/minimal.diff
Original file line number Diff line number Diff line change
@@ -1,15 +1,3 @@
diff -urN ./gc-8.2.4/configure /home/ahgamut/sources/gc-8.2.4/configure
--- ./gc-8.2.4/configure 2023-05-26 18:57:16.000000000 +0000
+++ ./gc-8.2.4/configure 2023-11-09 05:30:07.671209178 +0000
@@ -17184,7 +17184,7 @@
# We should set -fexceptions if we are using gcc and might be used
# inside something like gcj. This is the zeroth approximation:
if test :"$GCC": = :yes: ; then
- gc_cflags="${gc_cflags} -fexceptions"
+ gc_cflags="${gc_cflags} "
else
case "$host" in
hppa*-*-hpux* )
diff -urN ./gc-8.2.4/include/private/gcconfig.h /home/ahgamut/sources/gc-8.2.4/include/private/gcconfig.h
--- ./gc-8.2.4/include/private/gcconfig.h 2023-05-26 18:56:18.000000000 +0000
+++ ./gc-8.2.4/include/private/gcconfig.h 2023-11-09 05:30:49.391450600 +0000
Expand Down

2 comments on commit eb5fd41

@ivmai
Copy link

@ivmai ivmai commented on eb5fd41 Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with -fexceptions support, all the tests appear to pass.
sometimes the gctest check takes a bit on aarch64 on QEMU.

@ahgamut What's the issue with -fexceptions? All tests pass even with -fexceptions passed to cosmocc. (I tested with cosmocc-3.9.3, see details in ivmai/bdwgc#666)

@ivmai
Copy link

@ivmai ivmai commented on eb5fd41 Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, got it, you have reverted previous change.

Please sign in to comment.