Add option to preserve trailing whitespace #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a `safeIdentifier` template function to strip special characters from anchor identifiers.
ahmetb
reviewed
Dec 14, 2020
| @@ -601,6 +608,7 @@ func render(w io.Writer, pkgs []*apiPackage, config generatorConfig) error { | |||
| "hiddenMember": func(m types.Member) bool { return hiddenMember(m, config) }, | |||
| "isLocalType": isLocalType, | |||
| "isOptionalMember": isOptionalMember, | |||
| "safeIdentifier": func(s string) string { return regexp.MustCompile("[[:punct:]]+").ReplaceAllLiteralString(s, "-") }, | |||
|
Yeah we can totally do this. The only reason we remove trailing spaces on each line is to prevent github markdown from misrendering it. I left one comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using my own set of templates to produce Asciidoc documents. Removing all trailing whitespace from the rendered document causes problems with Asciidoc rendering so this PR adds an option to preserve them.
It also adds a
safeIdentifiertemplate function to strip special characters from anchor identifiers. This is because some tools don't accept identifiers such astype.domain.com/v1