gdb: enable -Wmissing-prototypes warning

While compiling with clang, I noticed it didn't catch cases where my function declaration didn't match my function definition. This is normally caught by gcc with -Wmissing-declarations. On clang, this is caught by -Wmissing-prototypes instead. Note that on gcc, -Wmissing-prototypes also exists, but is only valid for C and Objective-C. It gets correctly rejected by the configure script since gcc rejects it with: cc1plus: error: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++ -Werror So this warning flag ends up not used for gcc (which is what we want). gdb/ChangeLog: * configure: Re-generate. gdbserver/ChangeLog: * configure: Re-generate. gdbsupport/ChangeLog: * configure: Re-generate. * warning.m4: Enable -Wmissing-prototypes.
ahomescu · Mar 11, 2020 · a0761e3 · a0761e3
1 parent 5308d1e
commit a0761e3
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 0 deletions.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-11  Simon Marchi  <[email protected]>
+
+	* configure: Re-generate.
+
 2020-03-11  Tom Tromey  <[email protected]>
 
 	* ada-typeprint.c (print_choices): Fix comment.

diff --git a/gdb/configure b/gdb/configure
@@ -16323,6 +16323,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wdeprecated-copy-dtor \
 -Wredundant-move \
 -Wmissing-declarations \
+-Wmissing-prototypes \
 -Wstrict-null-sentinel \
 "
 

diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-11  Simon Marchi  <[email protected]>
+
+	* configure: Re-generate.
+
 2020-03-06  Andrew Burgess  <[email protected]>
 
 	* .dir-locals.el: New file.

diff --git a/gdbserver/configure b/gdbserver/configure
@@ -9616,6 +9616,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wdeprecated-copy-dtor \
 -Wredundant-move \
 -Wmissing-declarations \
+-Wmissing-prototypes \
 -Wstrict-null-sentinel \
 "
 

diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-11  Simon Marchi  <[email protected]>
+
+	* configure: Re-generate.
+	* warning.m4: Enable -Wmissing-prototypes.
+
 2020-03-08  Tom Tromey  <[email protected]>
 
 	* gdb_binary_search.h: Fix two typos.

diff --git a/gdbsupport/configure b/gdbsupport/configure
@@ -10874,6 +10874,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wdeprecated-copy-dtor \
 -Wredundant-move \
 -Wmissing-declarations \
+-Wmissing-prototypes \
 -Wstrict-null-sentinel \
 "
 

diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4
@@ -51,6 +51,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wdeprecated-copy-dtor \
 -Wredundant-move \
 -Wmissing-declarations \
+-Wmissing-prototypes \
 -Wstrict-null-sentinel \
 "