Use Cookie.__init__
instead of settings keys as a dict [Fixes #254]
#255
+14
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix issue #254
New Features/Changes
The functionality should've remained the same, it just fixes the deprecation warning that was emitted.
I'm unsure how this affects the min. supported version of Sanic, perhaps that should be updated too.
Open Questions and TODOs
secure
key. The original code did a falsey check, butFalse
is also a falsey value, so the code didn't set thesecure
key toFalse
, but rather left it at whatever it was by default. I fixed this by doing an explicitNone
check. Now, the TODO here is to check if my assumption/fix is correct.